cellular-infrastructure
/
osmo-msc
mirror of https://gerrit.osmocom.org/osmo-msc
9
0
Fork 0
Code Issues Releases Wiki Activity

SMPP: UCS2 data_coding is 0x08, not 0x80! 

As can clearly be seen from SMPP Spec v3.4 Chapter 5.2.19,
a SUBMIT-SM with data_coding == 0x08 is UCS2, not with 0x80.

Thanks to ciaby@rhizomatica.org for reporting the bug.
This commit is contained in:
Harald Welte 2014-02-21 13:21:03 +01:00
parent ca114432be
commit 7e40be3949
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
openbsc/src/libmsc/smpp_openbsc.c
View File

@ -163,7 +163,7 @@ static int submit_to_sms(struct gsm_sms **psms, struct gsm_network *net,
/* pass DCS 1:1 through from SMPP to GSM */
sms->data_coding_scheme = submit->data_coding;
mode = MODE_8BIT;
} else if (submit->data_coding == 0x80) {
} else if (submit->data_coding == 0x08) {
/* UCS-2 */
sms->data_coding_scheme = (2 << 2);
mode = MODE_8BIT;