cellular-infrastructure
/
osmo-msc
mirror of https://gerrit.osmocom.org/osmo-msc
9
0
Fork 0
Code Issues Releases Wiki Activity

nat: Do not allow the amount of pending responses to grow infinitely 

Limit the amount of pending DLCX responses to three times the amount
of available endpoints. Currently all MGCP messages are sent and handled
in sequence.
This commit is contained in:
Holger Hans Peter Freyther 2012-11-12 18:36:00 +01:00
parent 931ad6ac33
commit 7c831ecd19
1 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
openbsc/src/osmo-bsc_nat/bsc_mgcp_utils.c
View File

@ -347,6 +347,21 @@ static void remember_pending_dlcx(struct sccp_connections *con, uint32_t transac
stats->trans_id = transaction;
stats->msc_endpoint = con->msc_endp;
/*
* Too many pending requests.. let's remove the first two items.
*/
if (!llist_empty(&bsc->pending_dlcx) &&
bsc->pending_dlcx_count >= bsc->cfg->max_endpoints * 3) {
struct bsc_nat_call_stats *tmp;
LOGP(DNAT, LOGL_ERROR,
"Too many(%d) pending DLCX responses on BSC: %d\n",
bsc->pending_dlcx_count, bsc->cfg->nr);
bsc->pending_dlcx_count -= 1;
tmp = (struct bsc_nat_call_stats *) bsc->pending_dlcx.next;
llist_del(&tmp->entry);
talloc_free(tmp);
}
bsc->pending_dlcx_count += 1;
llist_add_tail(&stats->entry, &bsc->pending_dlcx);
}