From 765948231889cd6f3c5799f9c538693d0887c0b4 Mon Sep 17 00:00:00 2001 From: Vadim Yanitskiy Date: Wed, 19 Jun 2019 20:10:38 +0700 Subject: [PATCH] libmsc/gsm_04_11.c: do not abuse LOG_TRANS() in gsm411_alloc_mt_trans() This change is similar to I6b68a0f0b32eb126e0f7e914a314130254d28467. If we 100% sure that trans == NULL, it makes more sense to use generic LOGP(DLSMS, LOGL_*, ...) call, so the logs can reflect more information than such dummy prefix: trans(NULL NULL callref-0x0 tid-0) ... Change-Id: I3c1e633aee5dd7cd0d367404a3def9cffe0b3baa --- src/libmsc/gsm_04_11.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libmsc/gsm_04_11.c b/src/libmsc/gsm_04_11.c index 3a3ec8ce7..367cc6faf 100644 --- a/src/libmsc/gsm_04_11.c +++ b/src/libmsc/gsm_04_11.c @@ -1097,13 +1097,13 @@ static struct gsm_trans *gsm411_alloc_mt_trans(struct gsm_network *net, struct vlr_subscr *vsub) { struct msc_a *msc_a; - struct gsm_trans *trans = NULL; + struct gsm_trans *trans; int tid; /* Generate a new transaction ID */ tid = trans_assign_trans_id(net, vsub, TRANS_SMS); if (tid == -1) { - LOG_TRANS(trans, LOGL_ERROR, "No available transaction IDs\n"); + LOGP(DLSMS, LOGL_ERROR, "No available transaction IDs\n"); return NULL; }