cellular-infrastructure
/
osmo-msc
mirror of https://gerrit.osmocom.org/osmo-msc
8
0
Fork 0
Code Issues Releases Wiki Activity

improve logging on encryption, for Ciphering and HO 

log the algorithm and all keys instead of just Kc.

Change-Id: If7871dedda2b1fb115e6f00da1379ff2e3d68a10
neels/a54
Neels Hofmeyr 2021-06-23 23:54:43 +02:00
parent db07fdcbfc
commit 73d093a806
2 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/libmsc/msc_a.c
View File

@ -345,8 +345,12 @@ static int msc_a_ran_enc_ciphering(struct msc_a *msc_a, bool umts_aka, bool retr
}
if (msc_a->geran_encr.key_len)
LOG_MSC_A(msc_a, LOGL_DEBUG, "RAN encoding chose ciphering key %s\n",
osmo_hexdump_nospc(msc_a->geran_encr.key, msc_a->geran_encr.key_len));
LOG_MSC_A(msc_a, LOGL_DEBUG, "RAN encoding chose ciphering: A5/%d kc %s kc128 %s\n",
msc_a->geran_encr.alg_id - 1,
osmo_hexdump_nospc_c(OTC_SELECT, msc_a->geran_encr.key, msc_a->geran_encr.key_len),
msc_a->geran_encr.kc128_present ?
osmo_hexdump_nospc_c(OTC_SELECT, msc_a->geran_encr.kc128, sizeof(msc_a->geran_encr.kc128))
: "-");
return 0;
}

8
src/libmsc/msc_ho.c
View File

@ -408,6 +408,14 @@ static void msc_ho_send_handover_request(struct msc_a *msc_a)
},
};
if (msc_a->geran_encr.key_len)
LOG_MSC_A(msc_a, LOGL_DEBUG, "HO Request with ciphering: A5/%d kc %s kc128 %s\n",
msc_a->geran_encr.alg_id - 1,
osmo_hexdump_nospc_c(OTC_SELECT, msc_a->geran_encr.key, msc_a->geran_encr.key_len),
msc_a->geran_encr.kc128_present ?
osmo_hexdump_nospc_c(OTC_SELECT, msc_a->geran_encr.kc128, sizeof(msc_a->geran_encr.kc128))
: "-");
if (msc_a->cc.active_trans) {
if (mncc_bearer_cap_to_channel_type(&channel_type, &msc_a->cc.active_trans->bearer_cap)) {
msc_ho_failed(msc_a, GSM0808_CAUSE_EQUIPMENT_FAILURE,