cellular-infrastructure
/
osmo-msc
mirror of https://gerrit.osmocom.org/osmo-msc
9
0
Fork 0
Code Issues Releases Wiki Activity

add comments to clarify some complete l3 details 

Change-Id: I6e289900d38d97c346d615b71d36656254e6f2b5
This commit is contained in:
Neels Hofmeyr 2020-06-24 14:22:52 +02:00
parent a4a45252df
commit 68f50dad76
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/libmsc/gsm_04_08.c
View File

@ -1396,7 +1396,9 @@ static void msc_vlr_subscr_update(struct vlr_subscr *subscr)
msub_update_id(msub);
}
/* VLR informs us that the subscriber has been associated with a conn */
/* VLR informs us that the subscriber has been associated with a conn.
* The subscriber has *not* been authenticated yet, so the vsub should be protected from potentially invalid information
* from the msc_a. */
static int msc_vlr_subscr_assoc(void *msc_conn_ref,
struct vlr_subscr *vsub)
{
@ -1406,6 +1408,10 @@ static int msc_vlr_subscr_assoc(void *msc_conn_ref,
if (msub_set_vsub(msub, vsub))
return -EINVAL;
/* FIXME: would be better to modify vsub->* only after the subscriber is authenticated, in
* evaluate_acceptance_outcome(conn_accepted == true). */
vsub->cs.attached_via_ran = msc_a->c.ran->type;
/* In case we have already received Classmark Information before the VLR Subscriber was

2
src/libmsc/msc_a.c
View File

@ -1375,6 +1375,8 @@ int msc_a_ran_dec_from_msc_i(struct msc_a *msc_a, struct msc_a_ran_dec_data *d)
switch (msg->msg_type) {
case RAN_MSG_COMPL_L3:
/* In case the cell_id from Complete Layer 3 Information lacks a PLMN, write the configured PLMN code
* into msc_a->via_cell. Then overwrite with those bits obtained from Complete Layer 3 Information. */
msc_a->via_cell = (struct osmo_cell_global_id){
.lai.plmn = msc_a_net(msc_a)->plmn,
};