From 6556d3cb1da6718c2e884473010367041d4db8a5 Mon Sep 17 00:00:00 2001 From: Harald Welte Date: Wed, 25 Oct 2017 03:28:03 +0200 Subject: [PATCH] Rename osmo_fsm to avoid illegal space in name + more meaningful name A FSM doesn't need "FSM" in its name, as it is obvious that it is a FSM. Also, having two that are called RESET is confusing, so let's try to come up with better names. Also, after Change-Id I9ef59432f43a3cdb94e4cbb0c44ac3f9b2aac0f2 in libosmocore, we now enforce that no FSM identifiers contain spaces or other illegal characters. Closes: OS#2593 Change-Id: I858a81b8a4e01b2e802e3159f2835e5ca515953d --- src/libcommon-cs/a_reset.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libcommon-cs/a_reset.c b/src/libcommon-cs/a_reset.c index 9a226aca7..7dbd01462 100644 --- a/src/libcommon-cs/a_reset.c +++ b/src/libcommon-cs/a_reset.c @@ -124,7 +124,7 @@ static struct osmo_fsm_state fsm_states[] = { /* State machine definition */ static struct osmo_fsm fsm = { - .name = "FSM RESET", + .name = "A-RESET", .states = fsm_states, .num_states = ARRAY_SIZE(fsm_states), .log_subsys = DMSC, @@ -149,7 +149,7 @@ struct a_reset_ctx *a_reset_alloc(const void *ctx, const char *name, void *cb, v reset->cb = cb; strncpy(reset->name, name, sizeof(reset->name)); reset->conn_loss_counter = 0; - reset->fsm = osmo_fsm_inst_alloc(&fsm, NULL, NULL, LOGL_DEBUG, "FSM RESET INST"); + reset->fsm = osmo_fsm_inst_alloc(&fsm, NULL, NULL, LOGL_DEBUG, NULL); OSMO_ASSERT(reset->fsm); reset->fsm->priv = reset; LOGP(DMSC, LOGL_NOTICE, "(%s) reset handler fsm created.\n", reset->name);