From 5b1f9a2d0c744db565db6298b889984cd403923d Mon Sep 17 00:00:00 2001 From: Neels Hofmeyr Date: Sat, 6 Aug 2022 17:40:52 +0200 Subject: [PATCH] fix sdp_msg_to_sdp_str(), never add fmtp for unset codec Change-Id: I1892efd9360585f98419ebbd0df180f7f3a8160d --- src/libmsc/sdp_msg.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/libmsc/sdp_msg.c b/src/libmsc/sdp_msg.c index 97e871b57..49fc5d2c7 100644 --- a/src/libmsc/sdp_msg.c +++ b/src/libmsc/sdp_msg.c @@ -268,11 +268,10 @@ int sdp_msg_to_sdp_str_buf(char *dst, size_t dst_size, const struct sdp_msg *sdp /* Add details for all codecs */ foreach_sdp_audio_codec(codec, &sdp->audio_codecs) { - if (codec->subtype_name[0]) { - OSMO_STRBUF_PRINTF(sb, "a=rtpmap:%d %s/%d\r\n", codec->payload_type, codec->subtype_name, - codec->rate > 0? codec->rate : 8000); - } - + if (!sdp_audio_codec_is_set(codec)) + continue; + OSMO_STRBUF_PRINTF(sb, "a=rtpmap:%d %s/%d\r\n", codec->payload_type, codec->subtype_name, + codec->rate > 0 ? codec->rate : 8000); if (codec->fmtp[0]) OSMO_STRBUF_PRINTF(sb, "a=fmtp:%d %s\r\n", codec->payload_type, codec->fmtp); }