osmo_msc: remove unused parameter from msc_dtap()

The parameter link_id in the function msc_dtap() is unused. Lets remove
it.

Change-Id: I7ba67b0cb514c91bc87a7b396ed3962b7a68e7da
changes/35/11835/3
Philipp Maier 4 years ago committed by dexter
parent b7e5201b62
commit 54729d6e5e
  1. 3
      include/osmocom/msc/osmo_msc.h
  2. 2
      src/libmsc/a_iface_bssap.c
  3. 2
      src/libmsc/iucs.c
  4. 2
      src/libmsc/osmo_msc.c
  5. 2
      tests/msc_vlr/msc_vlr_tests.c

@ -63,8 +63,7 @@ void msc_sapi_n_reject(struct gsm_subscriber_connection *conn, int dlci);
int msc_clear_request(struct gsm_subscriber_connection *conn, uint32_t cause);
int msc_compl_l3(struct gsm_subscriber_connection *conn,
struct msgb *msg, uint16_t chosen_channel);
void msc_dtap(struct gsm_subscriber_connection *conn, uint8_t link_id,
struct msgb *msg);
void msc_dtap(struct gsm_subscriber_connection *conn, struct msgb *msg);
int msc_classmark_request_then_cipher_mode_cmd(struct gsm_subscriber_connection *conn, bool umts_aka,
bool retrieve_imeisv);
int msc_geran_set_cipher_mode(struct gsm_subscriber_connection *conn, bool umts_aka, bool retrieve_imeisv);

@ -686,7 +686,7 @@ static int rx_dtap(const struct osmo_sccp_user *scu, const struct a_conn_info *a
OMSC_LINKID_CB(msg) = dtap->link_id;
/* Forward dtap payload into the msc */
msc_dtap(conn, conn->a.conn_id, msg);
msc_dtap(conn, msg);
return 0;
}

@ -173,7 +173,7 @@ int gsm0408_rcvmsg_iucs(struct gsm_network *network, struct msgb *msg,
uint8_t pdisc = gh->proto_discr & 0x0f;
OSMO_ASSERT(pdisc != GSM48_PDISC_RR);
msc_dtap(conn, ue_ctx->conn_id, msg);
msc_dtap(conn, msg);
rc = 0;
} else {
/* allocate a new connection */

@ -121,7 +121,7 @@ int msc_compl_l3(struct gsm_subscriber_connection *conn,
}
/* Receive a DTAP message from BSC */
void msc_dtap(struct gsm_subscriber_connection *conn, uint8_t link_id, struct msgb *msg)
void msc_dtap(struct gsm_subscriber_connection *conn, struct msgb *msg)
{
msc_subscr_conn_get(conn, MSC_CONN_USE_DTAP);
gsm0408_dispatch(conn, msg);

@ -232,7 +232,7 @@ void rx_from_ms(struct msgb *msg)
&& (gsm48_hdr_msg_type(gh) == GSM48_MT_RR_CIPH_M_COMPL))
msc_cipher_mode_compl(g_conn, msg, 0);
else
msc_dtap(g_conn, 23, msg);
msc_dtap(g_conn, msg);
}
if (!conn_exists(g_conn))

Loading…
Cancel
Save