bsc_vty: Don't allow timers of zero (0)
It typically doesn't make sense to configure any of the GSM RR timer to 0 (Seconds). In fact, accidentially configuring any of the timers to zero might have severe side effects, such as "stuck channels" described in https://osmocom.org/issues/2380 Change-Id: I517828f2f0c80ec01cb63648db2626f17a67fe57
This commit is contained in:
parent
5d1fa89819
commit
50546a9adb
|
@ -1543,14 +1543,14 @@ DEFUN(cfg_net_pag_any_tch,
|
|||
#define DECLARE_TIMER(number, doc) \
|
||||
DEFUN(cfg_net_T##number, \
|
||||
cfg_net_T##number##_cmd, \
|
||||
"timer t" #number " <0-65535>", \
|
||||
"timer t" #number " <1-65535>", \
|
||||
"Configure GSM Timers\n" \
|
||||
doc "Timer Value in seconds\n") \
|
||||
{ \
|
||||
struct gsm_network *gsmnet = gsmnet_from_vty(vty); \
|
||||
int value = atoi(argv[0]); \
|
||||
\
|
||||
if (value < 0 || value > 65535) { \
|
||||
if (value < 1 || value > 65535) { \
|
||||
vty_out(vty, "Timer value %s out of range.%s", \
|
||||
argv[0], VTY_NEWLINE); \
|
||||
return CMD_WARNING; \
|
||||
|
|
Loading…
Reference in New Issue