From 4fa6c2f636261927a70677963109c569920e473f Mon Sep 17 00:00:00 2001 From: Vadim Yanitskiy Date: Fri, 22 Dec 2023 01:53:53 +0700 Subject: [PATCH] VTY: always print MNCC handler type (internal/external) ... so that it's clear which MNCC handler is used by looking at the output of `show running-config`. Change-Id: Id1fe7aecc1c8445db48ff5fddcf6df0f05ba5e2e --- src/libmsc/msc_vty.c | 2 ++ tests/test_nodes.vty | 9 +++++++-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/src/libmsc/msc_vty.c b/src/libmsc/msc_vty.c index f693cb6d9..1f389f455 100644 --- a/src/libmsc/msc_vty.c +++ b/src/libmsc/msc_vty.c @@ -763,6 +763,8 @@ static int config_write_msc(struct vty *vty) vty_out(vty, "msc%s", VTY_NEWLINE); if (gsmnet->mncc_sock_path) vty_out(vty, " mncc external %s%s", gsmnet->mncc_sock_path, VTY_NEWLINE); + else + vty_out(vty, " mncc internal%s", VTY_NEWLINE); vty_out(vty, " mncc guard-timeout %i%s", gsmnet->mncc_guard_timeout, VTY_NEWLINE); vty_out(vty, " ncss guard-timeout %i%s", diff --git a/tests/test_nodes.vty b/tests/test_nodes.vty index 836de665e..5e4b793b1 100644 --- a/tests/test_nodes.vty +++ b/tests/test_nodes.vty @@ -99,12 +99,16 @@ OsmoMSC(config-msc)# mncc external /path/not/used OsmoMSC(config-msc)# show running-config ... msc -... +... ! mncc internal mncc external /path/not/used -... +... ! mncc internal OsmoMSC(config-msc)# mncc internal OsmoMSC(config-msc)# show running-config +... +msc +... ! mncc external + mncc internal ... ! mncc external OsmoMSC(config-msc)# exit @@ -157,6 +161,7 @@ network mm info 1 ... msc + mncc internal mncc guard-timeout 180 ncss guard-timeout 30 assign-tmsi