libmsc/sgs_vty.c: always write server address and VLR name

Comparing an array to null is not useful, because the expression
will always evaluate as true. Let's just always write SGs server
address and VLR name, no mater whether default values are used
or not, same as we do for the HLR address and port.

Change-Id: If045e42fca0315b0777eb86c44bf934ce58b340b
Fixes: CID#190871 Array compared against 0 (NO_EFFECT)
changes/17/13017/4
Vadim Yanitskiy 4 years ago
parent e9ef7c6b9a
commit 4d75877e61
  1. 9
      src/libmsc/sgs_vty.c
  2. 1
      tests/test_nodes.vty

@ -158,12 +158,9 @@ static int config_write_sgs(struct vty *vty)
char str_buf[256];
vty_out(vty, "sgs%s", VTY_NEWLINE);
if (sgs->cfg.local_port != SGS_PORT_DEFAULT)
vty_out(vty, " local-port %u%s", sgs->cfg.local_port, VTY_NEWLINE);
if (sgs->cfg.local_addr)
vty_out(vty, " local-ip %s%s", sgs->cfg.local_addr, VTY_NEWLINE);
if (sgs->cfg.vlr_name)
vty_out(vty, " vlr-name %s%s", sgs->cfg.vlr_name, VTY_NEWLINE);
vty_out(vty, " local-port %u%s", sgs->cfg.local_port, VTY_NEWLINE);
vty_out(vty, " local-ip %s%s", sgs->cfg.local_addr, VTY_NEWLINE);
vty_out(vty, " vlr-name %s%s", sgs->cfg.vlr_name, VTY_NEWLINE);
for (i = 0; i < ARRAY_SIZE(sgs->cfg.timer); i++) {
if (sgs->cfg.timer[i] == sgs_state_timer_defaults[i])

@ -147,6 +147,7 @@ hlr
remote-ip 127.0.0.1
remote-port 4222
sgs
local-port 29118
local-ip 0.0.0.0
vlr-name vlr.example.net
end

Loading…
Cancel
Save