cellular-infrastructure
/
osmo-msc
mirror of https://gerrit.osmocom.org/osmo-msc
9
0
Fork 0
Code Issues Releases Wiki Activity

sms: Possiqble meamleak fix gsm340_rx_tpdu() 

Slight clean up of the code in gsm340_rx_tpdu() and a fix for
an unlikely, but possible memory leak there.
This commit is contained in:
Alexander Chemeris 2013-10-04 02:42:27 +02:00 committed by Holger Hans Peter Freyther
parent a3d41c9124
commit 4ad593c8f6
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
openbsc/src/libmsc/gsm_04_11.c
View File

@ -337,8 +337,8 @@ static int gsm340_rx_tpdu(struct gsm_subscriber_connection *conn, struct msgb *m
sms_alphabet = gsm338_get_sms_alphabet(gsms->data_coding_scheme);
if (sms_alphabet == 0xffffffff) {
sms_free(gsms);
return GSM411_RP_CAUSE_MO_NET_OUT_OF_ORDER;
rc = GSM411_RP_CAUSE_MO_NET_OUT_OF_ORDER;
goto out;
}
switch (sms_vpf) {
@ -359,7 +359,8 @@ static int gsm340_rx_tpdu(struct gsm_subscriber_connection *conn, struct msgb *m
default:
LOGP(DLSMS, LOGL_NOTICE,
"SMS Validity period not implemented: 0x%02x\n", sms_vpf);
return GSM411_RP_CAUSE_MO_NET_OUT_OF_ORDER;
rc = GSM411_RP_CAUSE_MO_NET_OUT_OF_ORDER;
goto out;
}
gsms->user_data_len = *smsp++;
if (gsms->user_data_len) {