From 480d8df3bff3a0302b3f6f9f5a3068d06cda4da7 Mon Sep 17 00:00:00 2001
From: Gerrit User 1000005 <1000005@035e6965-6537-41bd-912c-053f3cf69326>
Date: Tue, 26 Mar 2024 14:13:59 +0000
Subject: [PATCH] Update patch set 1

Patch Set 1:

(4 comments)

Patch-set: 1
Attention: {"person_ident":"Gerrit User 1000005 \u003c1000005@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000005\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1000004 \u003c1000004@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000005\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000005\u003e replied on the change"}
---
 3da4715f718dc8b695244ef4d9376f3724a9bb94 | 72 ++++++++++++++++++++++++
 1 file changed, 72 insertions(+)

diff --git a/3da4715f718dc8b695244ef4d9376f3724a9bb94 b/3da4715f718dc8b695244ef4d9376f3724a9bb94
index 0f17ac1df..0acbaa989 100644
--- a/3da4715f718dc8b695244ef4d9376f3724a9bb94
+++ b/3da4715f718dc8b695244ef4d9376f3724a9bb94
@@ -17,6 +17,24 @@
       "revId": "3da4715f718dc8b695244ef4d9376f3724a9bb94",
       "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
     },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "ee0aa82e_04e646a3",
+        "filename": "/COMMIT_MSG",
+        "patchSetId": 1
+      },
+      "lineNbr": 15,
+      "author": {
+        "id": 1000005
+      },
+      "writtenOn": "2024-03-26T14:13:59Z",
+      "side": 1,
+      "message": "interesting, which way around is that? do we also drop the old one there?",
+      "parentUuid": "344f85e7_d4a0d87a",
+      "revId": "3da4715f718dc8b695244ef4d9376f3724a9bb94",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
     {
       "unresolved": false,
       "key": {
@@ -34,6 +52,24 @@
       "revId": "3da4715f718dc8b695244ef4d9376f3724a9bb94",
       "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
     },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "4990e4f3_0617c662",
+        "filename": "/PATCHSET_LEVEL",
+        "patchSetId": 1
+      },
+      "lineNbr": 0,
+      "author": {
+        "id": 1000005
+      },
+      "writtenOn": "2024-03-26T14:13:59Z",
+      "side": 1,
+      "message": "I thought about that, too. The situation is:\n\nThis happens before Auth:\n- the MSC gets a LU request by TMSI,\n- then requires the IMSI\n- the ID response for that triggers this de-duplication.\n- authentication follows.\n- we can copy auth tuples safely.\n- i am not copying state like the security status or FSM states that might skip important validations.\n- we always have to know a subscriber\u0027s IMSI, i.e. the code makes sure that an IMSI is known in order to contact the HLR. This triggers only in a situation where the IMSI is not yet known, i.e. only possible in the short phase before the ID Request, before auth. i.e. not possible to sneakily hijack another IMSI\u0027s security context.\n\nIf authentication is switched off, then this doesn\u0027t hold of course, but nothing else does either.",
+      "parentUuid": "9ce0e0e7_d2cfa366",
+      "revId": "3da4715f718dc8b695244ef4d9376f3724a9bb94",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
     {
       "unresolved": true,
       "key": {
@@ -87,6 +123,24 @@
       "revId": "3da4715f718dc8b695244ef4d9376f3724a9bb94",
       "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
     },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "7e963ad9_991297fe",
+        "filename": "src/libmsc/paging.c",
+        "patchSetId": 1
+      },
+      "lineNbr": 147,
+      "author": {
+        "id": 1000005
+      },
+      "writtenOn": "2024-03-26T14:13:59Z",
+      "side": 1,
+      "message": "yes, i wanted to keep that close together, but the use count put should happen in the end, while the if() should happen in the start... i\u0027ll drop a comment there",
+      "parentUuid": "eec2c848_83fe2660",
+      "revId": "3da4715f718dc8b695244ef4d9376f3724a9bb94",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
     {
       "unresolved": true,
       "key": {
@@ -103,6 +157,24 @@
       "message": "I\u0027d rpobably move all this code to its own function \"vsub_join()\" or alike.",
       "revId": "3da4715f718dc8b695244ef4d9376f3724a9bb94",
       "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "e207ac85_0f270790",
+        "filename": "src/libvlr/vlr.c",
+        "patchSetId": 1
+      },
+      "lineNbr": 597,
+      "author": {
+        "id": 1000005
+      },
+      "writtenOn": "2024-03-26T14:13:59Z",
+      "side": 1,
+      "message": "ack\n(the paging_request_join() function was supposed to be that own function, but then this code here grew and grew with more aspects to be taken care of...)",
+      "parentUuid": "ca39f788_f7e3f283",
+      "revId": "3da4715f718dc8b695244ef4d9376f3724a9bb94",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
     }
   ]
 }
\ No newline at end of file