From 47a9ea0634e877dbe3b7dede6fd8a5323d5cfcd7 Mon Sep 17 00:00:00 2001
From: Gerrit User 1000159 <1000159@035e6965-6537-41bd-912c-053f3cf69326>
Date: Tue, 27 Sep 2022 05:55:37 +0000
Subject: [PATCH] Update patch set 29

Patch Set 29:

(6 comments)

This change is ready for review.

Patch-set: 29
Work-in-progress: false
Attention: {"person_ident":"Gerrit User 1000005 \u003c1000005@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"Max replied on the change"}
Attention: {"person_ident":"Gerrit User 1000004 \u003c1000004@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"Max replied on the change"}
Attention: {"person_ident":"Gerrit User 1000159 \u003c1000159@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"Max replied on the change"}
Attention: {"person_ident":"Gerrit User 1000028 \u003c1000028@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"Max replied on the change"}
---
 8b6f08c78704efaa13aec7016263cc554629af35 | 90 ++++++++++++++++++++++++
 c45ea2dec5ac25fa2126f892d06ffb67cbc4c71e | 21 ++++++
 2 files changed, 111 insertions(+)
 create mode 100644 c45ea2dec5ac25fa2126f892d06ffb67cbc4c71e

diff --git a/8b6f08c78704efaa13aec7016263cc554629af35 b/8b6f08c78704efaa13aec7016263cc554629af35
index 77f88cc06..195d26005 100644
--- a/8b6f08c78704efaa13aec7016263cc554629af35
+++ b/8b6f08c78704efaa13aec7016263cc554629af35
@@ -17,6 +17,24 @@
       "revId": "8b6f08c78704efaa13aec7016263cc554629af35",
       "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
     },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "ae9590ca_0473d3d3",
+        "filename": "/COMMIT_MSG",
+        "patchSetId": 28
+      },
+      "lineNbr": 7,
+      "author": {
+        "id": 1000159
+      },
+      "writtenOn": "2022-09-27T05:55:37Z",
+      "side": 1,
+      "message": "Done",
+      "parentUuid": "0f4c540b_64b8ea6a",
+      "revId": "8b6f08c78704efaa13aec7016263cc554629af35",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
     {
       "unresolved": false,
       "key": {
@@ -87,6 +105,24 @@
       "revId": "8b6f08c78704efaa13aec7016263cc554629af35",
       "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
     },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "99471e7b_11b17d10",
+        "filename": "include/osmocom/smpp/smpp.h",
+        "patchSetId": 28
+      },
+      "lineNbr": 51,
+      "author": {
+        "id": 1000159
+      },
+      "writtenOn": "2022-09-27T05:55:37Z",
+      "side": 1,
+      "message": "Done",
+      "parentUuid": "dcbf9993_b50aaa3a",
+      "revId": "8b6f08c78704efaa13aec7016263cc554629af35",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
     {
       "unresolved": true,
       "key": {
@@ -104,6 +140,24 @@
       "revId": "8b6f08c78704efaa13aec7016263cc554629af35",
       "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
     },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "ba12ec78_4e4c538c",
+        "filename": "include/osmocom/smpp/smpp.h",
+        "patchSetId": 28
+      },
+      "lineNbr": 53,
+      "author": {
+        "id": 1000159
+      },
+      "writtenOn": "2022-09-27T05:55:37Z",
+      "side": 1,
+      "message": "Done",
+      "parentUuid": "683ef905_fe48acca",
+      "revId": "8b6f08c78704efaa13aec7016263cc554629af35",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
     {
       "unresolved": true,
       "key": {
@@ -121,6 +175,24 @@
       "revId": "8b6f08c78704efaa13aec7016263cc554629af35",
       "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
     },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "820325a5_a2a32abb",
+        "filename": "include/osmocom/smpp/smpp.h",
+        "patchSetId": 28
+      },
+      "lineNbr": 55,
+      "author": {
+        "id": 1000159
+      },
+      "writtenOn": "2022-09-27T05:55:37Z",
+      "side": 1,
+      "message": "I\u0027m also not convinced this is worth moving to libosmocore - I don\u0027t think macro with flow control is a good idea in general. But that\u0027s the comment in the comment in the original code - I\u0027ve simply kept it in place while moving it. I also keep the name intact for the same reason.",
+      "parentUuid": "95e06b96_0280d326",
+      "revId": "8b6f08c78704efaa13aec7016263cc554629af35",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
     {
       "unresolved": true,
       "key": {
@@ -138,6 +210,24 @@
       "revId": "8b6f08c78704efaa13aec7016263cc554629af35",
       "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
     },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "816b746f_6f579534",
+        "filename": "src/libsmpputil/smpp_utils.c",
+        "patchSetId": 28
+      },
+      "lineNbr": 58,
+      "author": {
+        "id": 1000159
+      },
+      "writtenOn": "2022-09-27T05:55:37Z",
+      "side": 1,
+      "message": "Done",
+      "parentUuid": "75c3dae7_8579125f",
+      "revId": "8b6f08c78704efaa13aec7016263cc554629af35",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
     {
       "unresolved": true,
       "key": {
diff --git a/c45ea2dec5ac25fa2126f892d06ffb67cbc4c71e b/c45ea2dec5ac25fa2126f892d06ffb67cbc4c71e
new file mode 100644
index 000000000..f76231352
--- /dev/null
+++ b/c45ea2dec5ac25fa2126f892d06ffb67cbc4c71e
@@ -0,0 +1,21 @@
+{
+  "comments": [
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "1af9d5e5_c526ea5e",
+        "filename": "/PATCHSET_LEVEL",
+        "patchSetId": 29
+      },
+      "lineNbr": 0,
+      "author": {
+        "id": 1000159
+      },
+      "writtenOn": "2022-09-27T05:55:37Z",
+      "side": 1,
+      "message": "The fixes are included into next revision.",
+      "revId": "c45ea2dec5ac25fa2126f892d06ffb67cbc4c71e",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    }
+  ]
+}
\ No newline at end of file