From 4547cf1c9972f27f3892c5e8a2150f9f8cb41fdc Mon Sep 17 00:00:00 2001 From: Vadim Yanitskiy Date: Mon, 20 Apr 2020 10:42:28 +0700 Subject: [PATCH] SMS-over-GSUP: notify sender about malformed GSUP messages Change-Id: I27f00e69ff045cbf641ef21adf44fcd55cb8f889 --- src/libmsc/gsm_04_11_gsup.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/libmsc/gsm_04_11_gsup.c b/src/libmsc/gsm_04_11_gsup.c index cf9d11d2e..7c9b6fb50 100644 --- a/src/libmsc/gsm_04_11_gsup.c +++ b/src/libmsc/gsm_04_11_gsup.c @@ -178,9 +178,8 @@ static int gsm411_gsup_mo_handler(struct gsm_network *net, struct vlr_subscr *vs return 0; msg_error: - /* TODO: notify sender about that? */ - LOGP(DLSMS, LOGL_NOTICE, "RX malformed %s-%s\n", - msg_name, msg_is_err ? "Err" : "Res"); + LOGP(DLSMS, LOGL_NOTICE, "RX malformed %s-%s\n", msg_name, msg_is_err ? "Err" : "Res"); + gsup_client_mux_tx_error_reply(net->gcm, gsup_msg, GMM_CAUSE_INV_MAND_INFO); return -EINVAL; } @@ -269,8 +268,8 @@ static int gsm411_gsup_mt_handler(struct gsm_network *net, struct vlr_subscr *vs return 0; msg_error: - /* TODO: notify sender about that? */ LOGP(DLSMS, LOGL_NOTICE, "RX malformed MT-forwardSM-Req\n"); + gsup_client_mux_tx_error_reply(net->gcm, gsup_msg, GMM_CAUSE_INV_MAND_INFO); return -EINVAL; }