From 4061a76d5cdd0a99c44a22fe0da44740efc521b1 Mon Sep 17 00:00:00 2001 From: Gerrit User 1000074 <1000074@035e6965-6537-41bd-912c-053f3cf69326> Date: Wed, 19 Oct 2022 10:21:42 +0000 Subject: [PATCH] Update patch set 10 Patch Set 10: (1 comment) Patch-set: 10 Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"pespin replied on the change"} Attention: {"person_ident":"Gerrit User 1000159 \u003c1000159@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"pespin replied on the change"} --- 947b159b88301a24bbbd1faec095e540ab0ffbcc | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 947b159b88301a24bbbd1faec095e540ab0ffbcc diff --git a/947b159b88301a24bbbd1faec095e540ab0ffbcc b/947b159b88301a24bbbd1faec095e540ab0ffbcc new file mode 100644 index 000000000..6dffa4095 --- /dev/null +++ b/947b159b88301a24bbbd1faec095e540ab0ffbcc @@ -0,0 +1,21 @@ +{ + "comments": [ + { + "unresolved": true, + "key": { + "uuid": "4426a07d_d24fe376", + "filename": "src/libsmpputil/smpp_smsc.c", + "patchSetId": 10 + }, + "lineNbr": 978, + "author": { + "id": 1000074 + }, + "writtenOn": "2022-10-19T10:21:42Z", + "side": 1, + "message": "You are calling \"port ? port : SMPP_PORT\" three times.\nDo once \"port \u003d (port ? : SMPP_PORT);\" and simplify the code.", + "revId": "947b159b88301a24bbbd1faec095e540ab0ffbcc", + "serverId": "035e6965-6537-41bd-912c-053f3cf69326" + } + ] +} \ No newline at end of file