cellular-infrastructure
/
osmo-msc
mirror of https://gerrit.osmocom.org/osmo-msc
9
0
Fork 0
Code Issues Releases Wiki Activity

Update patch set 10 

Patch Set 10:

(1 comment)

Patch-set: 10
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"pespin replied on the change"}
Attention: {"person_ident":"Gerrit User 1000159 \u003c1000159@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"pespin replied on the change"}
This commit is contained in:
Gerrit User 1000074 2022-10-19 10:21:42 +00:00 committed by Gerrit Code Review
parent 0204813ad8
commit 4061a76d5c
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
947b159b88301a24bbbd1faec095e540ab0ffbcc Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "4426a07d_d24fe376",
"filename": "src/libsmpputil/smpp_smsc.c",
"patchSetId": 10
},
"lineNbr": 978,
"author": {
"id": 1000074
},
"writtenOn": "2022-10-19T10:21:42Z",
"side": 1,
"message": "You are calling \"port ? port : SMPP_PORT\" three times.\nDo once \"port \u003d (port ? : SMPP_PORT);\" and simplify the code.",
"revId": "947b159b88301a24bbbd1faec095e540ab0ffbcc",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}