cellular-infrastructure
/
osmo-msc
mirror of https://gerrit.osmocom.org/osmo-msc
9
0
Fork 0
Code Issues Releases Wiki Activity

Update patch set 52 

Patch Set 52:

(3 comments)

Patch-set: 52
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"Max replied on the change"}
Attention: {"person_ident":"Gerrit User 1000159 \u003c1000159@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"Max replied on the change"}
This commit is contained in:
Gerrit User 1000159 2022-10-27 15:46:54 +00:00 committed by Gerrit Code Review
parent 7b77108693
commit 2cc3e41bca
1 changed files with 54 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
7d7fc04e8126aab46d6b5ab63e618f93d775b128
View File

@ -245,6 +245,24 @@
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "5a0fbee5_158f3b3c",
"filename": "src/libsmpputil/smpp_smsc.c",
"patchSetId": 49
},
"lineNbr": 791,
"author": {
"id": 1000159
},
"writtenOn": "2022-10-27T15:46:54Z",
"side": 1,
"message": "Done",
"parentUuid": "87acba4a_fdaf05b6",
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
@ -314,6 +332,24 @@
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "ceeb2be8_9ad8ceda",
"filename": "src/libsmpputil/smpp_smsc.c",
"patchSetId": 49
},
"lineNbr": 825,
"author": {
"id": 1000159
},
"writtenOn": "2022-10-27T15:46:54Z",
"side": 1,
"message": "Indeed, better rename it and make static. Though I think it\u0027s better to keep it as a separate function since it makes it easier to read.",
"parentUuid": "fddefff1_066f7386",
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
@ -472,6 +508,24 @@
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "4c943b1f_19391996",
"filename": "src/libsmpputil/smpp_smsc.c",
"patchSetId": 49
},
"lineNbr": 985,
"author": {
"id": 1000159
},
"writtenOn": "2022-10-27T15:46:54Z",
"side": 1,
"message": "Actually, assigning NULL in here breaks the ext tests.",
"parentUuid": "f914e08c_49c1f6fa",
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {