cellular-infrastructure
/
osmo-msc
mirror of https://gerrit.osmocom.org/osmo-msc
9
0
Fork 0
Code Issues Releases Wiki Activity

setup_trig_pag_evt: Remove uneeded default case in switch statement 

Take the chance to  pass a var of type enum instead, so the compiler
warns us if a new enum value is added. For instance, if we remove
GSM_PAGING_EXPIRED from the switch statement:

src/libmsc/gsm_04_08.c:1463:2: warning: enumeration value ‘GSM_PAGING_EXPIRED’ not handled in switch [-Wswitch]
  switch (paging_event) {
  ^~~~~~

Change-Id: I65d871704b9636c594dc982200fbe7f7ce6784f5
This commit is contained in:
Pau Espin 2018-04-24 11:46:58 +02:00
parent 4cf452fbd8
commit 25adebea4c
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/libmsc/gsm_04_08.c
View File

@ -1456,10 +1456,11 @@ static int setup_trig_pag_evt(unsigned int hooknum, unsigned int event,
{
struct gsm_subscriber_connection *conn = _conn;
struct gsm_trans *transt = _transt;
enum gsm_paging_event paging_event = event;
OSMO_ASSERT(!transt->conn);
switch (event) {
switch (paging_event) {
case GSM_PAGING_SUCCEEDED:
DEBUGP(DCC, "Paging subscr %s succeeded!\n",
vlr_subscr_msisdn_or_name(transt->vsub));
@ -1482,9 +1483,6 @@ static int setup_trig_pag_evt(unsigned int hooknum, unsigned int event,
transt->paging_request = NULL;
trans_free(transt);
break;
default:
LOGP(DCC, LOGL_ERROR, "Unknown paging event %d\n", event);
break;
}
transt->paging_request = NULL;