cellular-infrastructure
/
osmo-msc
mirror of https://gerrit.osmocom.org/osmo-msc
9
0
Fork 0
Code Issues Releases Wiki Activity

Update patch set 1 

Patch Set 1:

(1 comment)

Patch-set: 1
Attention: {"person_ident":"Gerrit User 1000005 \u003c1000005@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"neels replied on the change"}
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"neels replied on the change"}
This commit is contained in:
Gerrit User 1000005 2022-10-26 16:03:28 +00:00 committed by Gerrit Code Review
parent e6f9ea1642
commit 1d6ddaec9e
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
59d74b3956772e07becca87cd3dd7f9848c48d8c
View File

@ -34,6 +34,24 @@
"revId": "59d74b3956772e07becca87cd3dd7f9848c48d8c",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "c755ddfa_44b9aee2",
"filename": "src/libvlr/vlr_access_req_fsm.c",
"patchSetId": 1
},
"lineNbr": 662,
"author": {
"id": 1000005
},
"writtenOn": "2022-10-26T16:03:28Z",
"side": 1,
"message": "it can never happen, see the callers in gsm_04_08.c. But i can add an assert.\n\nin general, we don\u0027t assert / guard against everything in non-public API, otherwise we would have e.g. assertions for non-NULL pointers absolutely everywhere.\nit makes sense to not clutter the code with code paths that can never happen.",
"parentUuid": "66f0fe9d_3aafa16c",
"revId": "59d74b3956772e07becca87cd3dd7f9848c48d8c",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {