cellular-infrastructure
/
osmo-msc
mirror of https://gerrit.osmocom.org/osmo-msc
9
0
Fork 0
Code Issues Releases Wiki Activity

Add support for pdpctx_timer_stop 

Timer T3395 starts  at the transmission of Deactivate PDP request using
pdpctx_timer_start  but there was no corresponding stop function.
The timer is stopped when Deactivate PDP Context Accept is received.
This according to 3gpp spec reference 24.008 section 6.1.3.4.2.

Change-Id: I825c0a47d39e784dd1b8251f564609262530a5c6
This commit is contained in:
Pravin Kumarvel 2016-11-17 12:20:01 +05:30 committed by pravin
parent 5085e0bf4c
commit 16606c9007
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
openbsc/src/gprs/gprs_gmm.c
View File

@ -1990,6 +1990,14 @@ static void pdpctx_timer_start(struct sgsn_pdp_ctx *pdp, unsigned int T,
osmo_timer_schedule(&pdp->timer, seconds, 0);
}
static void pdpctx_timer_stop(struct sgsn_pdp_ctx *pdp, unsigned int T)
{
if (pdp->T != T)
LOGPDPCTXP(LOGL_ERROR, pdp, "Stopping PDP timer %u but "
"%u is running\n", T, pdp->T);
osmo_timer_del(&pdp->timer);
}
#if 0
static void msgb_put_pdp_addr_ipv4(struct msgb *msg, uint32_t ipaddr)
{
@ -2464,7 +2472,8 @@ static int gsm48_rx_gsm_deact_pdp_ack(struct sgsn_mm_ctx *mm, struct msgb *msg)
mm->imsi, transaction_id);
return 0;
}
/* stop timer 3395 */
pdpctx_timer_stop(pdp, 3395);
return sgsn_delete_pdp_ctx(pdp);
}