cellular-infrastructure
/
osmo-msc
mirror of https://gerrit.osmocom.org/osmo-msc
9
0
Fork 0
Code Issues Releases Wiki Activity

libmsc/gsm_04_11.c: don't pass msgb to gsm411_rx_rp_{ack|error} 

Passing a message buffer containing the whole encoded message, and
a pointer to the RP header (struct gsm411_rp_hdr) is redundant.

Change-Id: I0eb5c7c485ab7d109966431bd875fa74e00936d7
This commit is contained in:
Vadim Yanitskiy 2018-11-22 16:54:36 +07:00
parent 54729d6e5e
commit 0c8998f066
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/libmsc/gsm_04_11.c
View File

@ -700,7 +700,7 @@ static void sms_status_report(struct gsm_sms *gsms,
}
/* Receive a 04.11 RP-ACK message (response to RP-DATA from us) */
static int gsm411_rx_rp_ack(struct msgb *msg, struct gsm_trans *trans,
static int gsm411_rx_rp_ack(struct gsm_trans *trans,
struct gsm411_rp_hdr *rph)
{
struct gsm_sms *sms = trans->sms.sms;
@ -729,7 +729,7 @@ static int gsm411_rx_rp_ack(struct msgb *msg, struct gsm_trans *trans,
return 0;
}
static int gsm411_rx_rp_error(struct msgb *msg, struct gsm_trans *trans,
static int gsm411_rx_rp_error(struct gsm_trans *trans,
struct gsm411_rp_hdr *rph)
{
struct gsm_network *net = trans->conn->network;
@ -824,11 +824,11 @@ static int gsm411_rx_rl_report(struct msgb *msg, struct gsm48_hdr *gh,
switch (msg_type) {
case GSM411_MT_RP_ACK_MO:
DEBUGP(DLSMS, "RX SMS RP-ACK (MO)\n");
rc = gsm411_rx_rp_ack(msg, trans, rp_data);
rc = gsm411_rx_rp_ack(trans, rp_data);
break;
case GSM411_MT_RP_ERROR_MO:
DEBUGP(DLSMS, "RX SMS RP-ERROR (MO)\n");
rc = gsm411_rx_rp_error(msg, trans, rp_data);
rc = gsm411_rx_rp_error(trans, rp_data);
break;
default:
LOGP(DLSMS, LOGL_NOTICE, "Invalid RP type 0x%02x\n", msg_type);