Revert "gprs: Use RAND_bytes for p-tmsi"

The commit not compiling/linking should have been a strong
indicator that it has not been tested either.

This reverts commit 6cf0249dac.
This commit is contained in:
Holger Hans Peter Freyther 2015-10-12 09:55:59 +02:00
parent f3316e30d6
commit fa07b489dc
3 changed files with 2 additions and 8 deletions

View File

@ -30,5 +30,4 @@ osmo_sgsn_SOURCES = gprs_gmm.c gprs_sgsn.c gprs_sndcp.c gprs_sndcp_vty.c \
gsm_04_08_gprs.c sgsn_cdr.c sgsn_ares.c
osmo_sgsn_LDADD = \
$(top_builddir)/src/libcommon/libcommon.a \
-lgtp $(OSMO_LIBS) $(LIBOSMOABIS_LIBS) $(LIBCARES_LIBS) \
$(LIBCRYPTO_LIBS) -lrt
-lgtp $(OSMO_LIBS) $(LIBOSMOABIS_LIBS) $(LIBCARES_LIBS) -lrt

View File

@ -41,8 +41,6 @@
#include <time.h>
#include <openssl/rand.h>
#define GPRS_LLME_CHECK_TICK 30
extern struct sgsn_instance *sgsn;
@ -527,9 +525,7 @@ uint32_t sgsn_alloc_ptmsi(void)
int max_retries = 100;
restart:
if (RAND_bytes((uint8_t *) &ptmsi, sizeof(ptmsi)) != 1)
goto failed;
ptmsi = rand();
/* Enforce that the 2 MSB are set without loosing the distance between
* identical values. Since rand() has no duplicate values within a
* period (because the size of the state is the same like the size of

View File

@ -34,6 +34,5 @@ sgsn_test_LDADD = \
$(LIBOSMOGSM_LIBS) \
$(LIBOSMOGB_LIBS) \
$(LIBCARES_LIBS) \
$(LIBCRYPTO_LIBS) \
-lgtp -lrt