From d57310731f8449251816ea1be85d30960e2cd141 Mon Sep 17 00:00:00 2001 From: Neels Hofmeyr Date: Thu, 15 Jul 2021 01:36:47 +0200 Subject: [PATCH] mgcp_client: add logging on received MGCP messages There is verbose debug logging on MGCP messages sent out to the MGW, but none on received MGCP messages. Add Rx logging. Related: SYS#5529 Change-Id: Id76230896aa87c1a12bd5ad87a62430c048a2873 --- src/libosmo-mgcp-client/mgcp_client.c | 3 +++ tests/mgcp_client/mgcp_client_test.err | 1 + 2 files changed, 4 insertions(+) diff --git a/src/libosmo-mgcp-client/mgcp_client.c b/src/libosmo-mgcp-client/mgcp_client.c index 8e6780ebc..9d60ee889 100644 --- a/src/libosmo-mgcp-client/mgcp_client.c +++ b/src/libosmo-mgcp-client/mgcp_client.c @@ -677,6 +677,9 @@ int mgcp_client_rx(struct mgcp_client *mgcp, struct msgb *msg) goto error; } + LOGP(DLMGCP, LOGL_DEBUG, "MGCP client: Rx %d %u %s\n", + r->head.response_code, r->head.trans_id, r->head.comment); + rc = parse_head_params(r); if (rc) { LOGP(DLMGCP, LOGL_ERROR, "Cannot parse MGCP response (head parameters)\n"); diff --git a/tests/mgcp_client/mgcp_client_test.err b/tests/mgcp_client/mgcp_client_test.err index 80119cbbc..e7db23ce8 100644 --- a/tests/mgcp_client/mgcp_client_test.err +++ b/tests/mgcp_client/mgcp_client_test.err @@ -10,6 +10,7 @@ DLMGCP Cannot cancel, no such transaction: 1 - cancel succeeds DLMGCP Canceled transaction 1 - late response gets discarded +DLMGCP MGCP client: Rx 200 1 OK DLMGCP Cannot find matching MGCP transaction for trans_id 1 - canceling again does nothing DLMGCP Cannot cancel, no such transaction: 1