cellular-infrastructure
/
osmo-mgw
mirror of https://gerrit.osmocom.org/osmo-mgw
10
0
Fork 0
Code Issues Releases Wiki Activity

Improve OML failure report 

* clearly separate report parts
* use textual representation for failure cause if possible

Change-Id: I7a98a77011463021d0edd6ecfab1680e211f7e16
Related: OS#1615
This commit is contained in:
Max 2017-01-11 11:51:28 +01:00 committed by Harald Welte
parent 93bafb611a
commit a5e369300f
1 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
openbsc/src/libbsc/abis_nm.c
View File

@ -37,6 +37,7 @@
#include <openbsc/gsm_data.h>
#include <openbsc/debug.h>
#include <osmocom/core/msgb.h>
#include <osmocom/gsm/protocol/gsm_12_21.h>
#include <osmocom/gsm/tlv.h>
#include <osmocom/gsm/abis_nm.h>
#include <osmocom/core/talloc.h>
@ -281,25 +282,32 @@ static int rx_fail_evt_rep(struct msgb *mb)
const uint8_t *p_val;
char *p_text;
LOGPC(DNM, LOGL_ERROR, "Failure Event Report ");
LOGPC(DNM, LOGL_ERROR, "Failure Event Report: ");
abis_nm_tlv_parse(&tp, sign_link->trx->bts, foh->data, oh->length-sizeof(*foh));
if (TLVP_PRESENT(&tp, NM_ATT_EVENT_TYPE))
LOGPC(DNM, LOGL_ERROR, "Type=%s ",
LOGPC(DNM, LOGL_ERROR, "Type=%s, ",
abis_nm_event_type_name(*TLVP_VAL(&tp, NM_ATT_EVENT_TYPE)));
if (TLVP_PRESENT(&tp, NM_ATT_SEVERITY))
LOGPC(DNM, LOGL_ERROR, "Severity=%s ",
LOGPC(DNM, LOGL_ERROR, "Severity=%s, ",
abis_nm_severity_name(*TLVP_VAL(&tp, NM_ATT_SEVERITY)));
if (TLVP_PRESENT(&tp, NM_ATT_PROB_CAUSE)) {
p_val = TLVP_VAL(&tp, NM_ATT_PROB_CAUSE);
LOGPC(DNM, LOGL_ERROR, "Probable cause= %02X %02X %02X ", p_val[0], p_val[1], p_val[2]);
LOGPC(DNM, LOGL_ERROR, "Probable cause=%s: ",
get_value_string(abis_nm_pcause_type_names, p_val[0]));
if (p_val[0] == NM_PCAUSE_T_MANUF)
LOGPC(DNM, LOGL_ERROR, "%s, ",
get_value_string(abis_mm_event_cause_names,
osmo_load16be(p_val + 1)));
else
LOGPC(DNM, LOGL_ERROR, "%02X %02X ", p_val[1], p_val[2]);
}
if (TLVP_PRESENT(&tp, NM_ATT_ADD_TEXT)) {
p_val = TLVP_VAL(&tp, NM_ATT_ADD_TEXT);
p_text = talloc_strndup(tall_bsc_ctx, (const char *) p_val, TLVP_LEN(&tp, NM_ATT_ADD_TEXT));
if (p_text) {
LOGPC(DNM, LOGL_ERROR, "Additional Text=%s ", p_text);
LOGPC(DNM, LOGL_ERROR, "Additional Text=%s. ", p_text);
talloc_free(p_text);
}
}