From 8ab2bfa3bd6a2e08a14107bc659eadbb6308887a Mon Sep 17 00:00:00 2001 From: Gerrit User 1000028 <1000028@035e6965-6537-41bd-912c-053f3cf69326> Date: Wed, 26 Apr 2023 15:20:34 +0000 Subject: [PATCH] Update patch set 4 Patch Set 4: (2 comments) Patch-set: 4 --- 348312445f7deb4228f9fd073111b405dd88af5c | 48 ++++++++++++++++++++++++ 1 file changed, 48 insertions(+) diff --git a/348312445f7deb4228f9fd073111b405dd88af5c b/348312445f7deb4228f9fd073111b405dd88af5c index 3ac4c95f6..fadc91fed 100644 --- a/348312445f7deb4228f9fd073111b405dd88af5c +++ b/348312445f7deb4228f9fd073111b405dd88af5c @@ -23,6 +23,30 @@ "revId": "348312445f7deb4228f9fd073111b405dd88af5c", "serverId": "035e6965-6537-41bd-912c-053f3cf69326" }, + { + "unresolved": false, + "key": { + "uuid": "11fa5b13_7187e1f3", + "filename": "/COMMIT_MSG", + "patchSetId": 3 + }, + "lineNbr": 9, + "author": { + "id": 1000028 + }, + "writtenOn": "2023-04-26T15:20:34Z", + "side": 1, + "message": "As far as I understand a call agent is any entity that controls an MGW, it can be a BSC, MSC or a PBX.", + "parentUuid": "34973814_525a87f3", + "range": { + "startLine": 9, + "startChar": 36, + "endLine": 9, + "endChar": 46 + }, + "revId": "348312445f7deb4228f9fd073111b405dd88af5c", + "serverId": "035e6965-6537-41bd-912c-053f3cf69326" + }, { "unresolved": true, "key": { @@ -45,6 +69,30 @@ }, "revId": "348312445f7deb4228f9fd073111b405dd88af5c", "serverId": "035e6965-6537-41bd-912c-053f3cf69326" + }, + { + "unresolved": false, + "key": { + "uuid": "eb90af28_86187357", + "filename": "src/libosmo-mgcp/mgcp_network.c", + "patchSetId": 3 + }, + "lineNbr": 1168, + "author": { + "id": 1000028 + }, + "writtenOn": "2023-04-26T15:20:34Z", + "side": 1, + "message": "I think in this case LOGL_NOTICE it is not a too big problem. mgcp_patch_pt() only fails on short RTP packets or if the codec decision is not made properly.", + "parentUuid": "97bfe5d5_311c677a", + "range": { + "startLine": 1168, + "startChar": 29, + "endLine": 1168, + "endChar": 34 + }, + "revId": "348312445f7deb4228f9fd073111b405dd88af5c", + "serverId": "035e6965-6537-41bd-912c-053f3cf69326" } ] } \ No newline at end of file