cellular-infrastructure
/
osmo-mgw
mirror of https://gerrit.osmocom.org/osmo-mgw
10
0
Fork 0
Code Issues Releases Wiki Activity

bsc_msc_ip.c: Return after having freed the msgb 

When reading MGCP is failing (e.g. because the udp socket
is not connected yet) we would have freed the msgb but we
didn't return and then executed msgb_put on a dead buffer.
This commit is contained in:
Holger Hans Peter Freyther 2010-04-02 03:28:30 +02:00
parent 8aaec620da
commit 44d92b4728
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
openbsc/src/bsc_msc_ip.c
View File

@ -603,9 +603,14 @@ static int mgcp_do_read(struct bsc_fd *fd)
ret = read(fd->fd, mgcp->data, mgcp->len);
if (ret <= 0) {
LOGP(DMGCP, LOGL_ERROR, "Failed to read: %d\n", errno);
LOGP(DMGCP, LOGL_ERROR, "Failed to read: %d/%s\n", errno, strerror(errno));
msgb_free(mgcp);
}
return -1;
} else if (ret > 4096 - 128) {
LOGP(DMGCP, LOGL_ERROR, "Too much data: %d\n", ret);
msgb_free(mgcp);
return -1;
}
msgb_put(mgcp, ret);
msc_queue_write(mgcp, NAT_IPAC_PROTO_MGCP);