From 0b6faa4521e6cba3cc235b2050712b49689406a5 Mon Sep 17 00:00:00 2001 From: Vadim Yanitskiy Date: Mon, 18 Apr 2022 02:29:37 +0300 Subject: [PATCH] libosmo-mgcp: e1: fix memleaks in e1_recv_cb() Change-Id: I4be9e6d09b34e792f24c9f09d19dce15b9dfbe3f Fixes: OS#5533 --- src/libosmo-mgcp/mgcp_e1.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/libosmo-mgcp/mgcp_e1.c b/src/libosmo-mgcp/mgcp_e1.c index e88b8c524..9a6efe23d 100644 --- a/src/libosmo-mgcp/mgcp_e1.c +++ b/src/libosmo-mgcp/mgcp_e1.c @@ -338,6 +338,7 @@ static void e1_recv_cb(struct e1inp_ts *ts, struct msgb *msg) trunk = mgcp_trunk_by_line_num(cfg, ts->line->num); if (!trunk) { LOGP(DE1, LOGL_ERROR, "E1-RX: unable to find a trunk for E1-line %u!\n", ts->line->num); + msgb_free(msg); return; } @@ -359,6 +360,9 @@ static void e1_recv_cb(struct e1inp_ts *ts, struct msgb *msg) /* Trigger sending of pending E1 traffic */ e1_send(ts, trunk); + + /* e1inp_rx_ts() does not free() msgb */ + msgb_free(msg); } static int e1_init(struct mgcp_trunk *trunk, uint8_t ts_nr)