2017-09-19 14:06:06 +00:00
|
|
|
# When cleaning up this file upon a release:
|
|
|
|
|
#
|
|
|
|
|
# - Note that the release version number is entirely unrelated to the API
|
|
|
|
|
# versions. A release version 5.2.3 may happily have an API version of 42:7:5.
|
|
|
|
|
#
|
|
|
|
|
# - Bump API version in src/lib*/Makefile.am files according to chapter
|
|
|
|
|
# "Library interface versions" of the libtool documentation.
|
|
|
|
|
# https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html
|
|
|
|
|
#
|
|
|
|
|
# - Iff the 'current' API version has changed, rename debian/lib*.install
|
|
|
|
|
#
|
|
|
|
|
# API version bumping for the impatient:
|
|
|
|
|
# LIBVERSION=c:r:a (current:revision_of_current:backwards_compat_age)
|
|
|
|
|
# 5:2:4 means that
|
|
|
|
|
# - this implements version 5 of the API;
|
|
|
|
|
# - this is the 2nd (compatible) revision of API version 5;
|
|
|
|
|
# - this is backwards compatible to all APIs since 4 versions ago,
|
|
|
|
|
# i.e. callers that need API versions from 1 to 5 can use this.
|
|
|
|
|
#
|
|
|
|
|
# Bumping API versions recipe:
|
|
|
|
|
# If the library source code has changed at all since the last update, r++;
|
|
|
|
|
# If any interfaces have been added, removed, or changed since the last update, c++, r=0;
|
|
|
|
|
# If any interfaces have been added since the last public release, a++;
|
|
|
|
|
# If any interfaces have been removed or changed since the last public release, a=0.
|
|
|
|
|
#
|
2017-11-22 10:44:50 +00:00
|
|
|
#library what description / commit summary line
|
2023-12-07 01:32:00 +00:00
|
|
|
libosmo-mgcp-client remove public API These public API items have not been called by any of our osmo-programs
|
|
|
|
|
for many years. Any sane caller of libosmo-mgcp-client should use the
|
|
|
|
|
higher level osmo_mgcpc_* API instead. Move these to a private header:
|
|
|
|
|
struct mgcp_response_head
|
|
|
|
|
struct mgcp_response
|
|
|
|
|
struct mgcp_msg
|
|
|
|
|
mgcp_response_parse_params()
|
|
|
|
|
mgcp_client_tx()
|
|
|
|
|
mgcp_client_cancel()
|
|
|
|
|
mgcp_msg_gen()
|
|
|
|
|
mgcp_msg_trans_id()
|
client: collapse codecs[] and ptmap[]; allow codec variants
codecs[] is an array of enum osmo_mgcp_codecs.
ptmap[] is an array of { enum osmo_mgcp_codecs, unsigned int ptmap }.
MGCP lists first a bunch of payload type numbers and then specifies them
again for details, like the numbers 112, 96, 3 in this example:
m=audio <port> RTP/AVP 112 96 3
a=rtpmap:112 AMR/8000
a=rtpmap:96 VND.3GPP.IUFP/16000
a=rtpmap:3 GSM-FR/8000
So far we keep these lists in two separate arrays:
- codecs[], codecs_len stores the 'm=audio' list
- ptmap[], ptmap_len stores the 'a=rtpmap' list (and may omit some
elements present in codecs[])
This applies to both struct mgcp_response and struct mgcp_msg.
These are semantically identical, and the separation leads to checks,
conversions and dear hopes of correct ordering.
So let's keep only one list with both codec and payload type number in
it. The 'm=audio' list establishes the order of the pt numbers, and the
'a=rtpmap' list adds codec information to the established entries.
In the internal API structs mgcp_msg and mgcp_response, just drop the
codecs[] entirely.
In public API struct mgcp_conn_peer, keep the codecs[] array, mark it
deprecated, and provide a backwards compat conversion: if any caller
invokes mgcp_conn_create() or mgcp_conn_modify() with codecs[] still
present in the verb_info arg, then move codecs[] entries over to the
ptmap[] array in a sensible way.
(BTW, even mgcp_conn_create() and mgcp_conn_modify() are never called
from outside of libosmo-mgcp-client in any of our osmo-cni programs;
users call osmo_mgcpc_ep_ci_add() and osmo_mgcpc_ep_ci_request(), which
in turn may pass user-provided codecs[] lists on to mgcp_conn_create() or
mgcp_conn_modify().)
Tests for parsing the MGCP response are mostly missing. They will be
added in upcoming patch I842ce65a9a70f313570857b7df53727cc572b9e6,
because they will be using only the new ptmap API.
Related: OS#6171
Change-Id: I798e02c6663376d3d52f4a74fc4b32411ce95bed
2023-12-07 02:46:46 +00:00
|
|
|
libosmo-mgcp-client deprecate public API New code should no longer use codecs[], instead use ptmap[].codec. There
|
|
|
|
|
is backwards compat code that moves codecs[] entries, if any, over to
|
|
|
|
|
ptmap[], so callers may migrate at own leisure.
|
2023-12-23 02:54:58 +00:00
|
|
|
osmo-mgw remove cfg Remove VTY config item 'sdp audio fmtp-extra' (see OS#6313)
|
2024-03-17 11:25:25 +00:00
|
|
|
libosmocore bump_dep; workaround Bump libosmocore version dependency after I68328adb952ca8833ba047cb3b49ccc6f8a1f1b5
|
|
|
|
|
has been merged to libosmocore.git; then remove my_msgb_copy_c wrapper function.
|
