{ "comments": [ { "unresolved": true, "key": { "uuid": "8be6c60c_63158110", "filename": "/PATCHSET_LEVEL", "patchSetId": 5 }, "lineNbr": 0, "author": { "id": 1000010 }, "writtenOn": "2022-01-29T10:16:47Z", "side": 1, "message": "Mostly cosmetic notes, not a merge blocker.", "revId": "0ef8e2eaed69c0923c9e224859d01ee66a77bf03", "serverId": "035e6965-6537-41bd-912c-053f3cf69326" }, { "unresolved": true, "key": { "uuid": "342a2125_b93c6a62", "filename": "/PATCHSET_LEVEL", "patchSetId": 5 }, "lineNbr": 0, "author": { "id": 1000004 }, "writtenOn": "2022-01-31T09:26:13Z", "side": 1, "message": "I think they are rather critical, thanks for finding them!", "parentUuid": "8be6c60c_63158110", "revId": "0ef8e2eaed69c0923c9e224859d01ee66a77bf03", "serverId": "035e6965-6537-41bd-912c-053f3cf69326" }, { "unresolved": false, "key": { "uuid": "685b1a20_6b39cb29", "filename": "/PATCHSET_LEVEL", "patchSetId": 5 }, "lineNbr": 0, "author": { "id": 1000028 }, "writtenOn": "2022-01-31T16:42:22Z", "side": 1, "message": "Thanks for reviewing this.", "parentUuid": "342a2125_b93c6a62", "revId": "0ef8e2eaed69c0923c9e224859d01ee66a77bf03", "serverId": "035e6965-6537-41bd-912c-053f3cf69326" }, { "unresolved": true, "key": { "uuid": "27b84377_1802f520", "filename": "include/osmocom/ranap/ranap_common.h", "patchSetId": 5 }, "lineNbr": 599, "author": { "id": 1000010 }, "writtenOn": "2022-01-29T10:16:47Z", "side": 1, "message": "Tippfehler: functions", "range": { "startLine": 599, "startChar": 36, "endLine": 599, "endChar": 45 }, "revId": "0ef8e2eaed69c0923c9e224859d01ee66a77bf03", "serverId": "035e6965-6537-41bd-912c-053f3cf69326" }, { "unresolved": false, "key": { "uuid": "adddf1bf_971d785d", "filename": "include/osmocom/ranap/ranap_common.h", "patchSetId": 5 }, "lineNbr": 599, "author": { "id": 1000028 }, "writtenOn": "2022-01-31T16:42:22Z", "side": 1, "message": "Done", "parentUuid": "27b84377_1802f520", "range": { "startLine": 599, "startChar": 36, "endLine": 599, "endChar": 45 }, "revId": "0ef8e2eaed69c0923c9e224859d01ee66a77bf03", "serverId": "035e6965-6537-41bd-912c-053f3cf69326" }, { "unresolved": true, "key": { "uuid": "7030b23e_7396dc5d", "filename": "src/ranap_common_ran.c", "patchSetId": 5 }, "lineNbr": 90, "author": { "id": 1000010 }, "writtenOn": "2022-01-29T10:16:47Z", "side": 1, "message": "successfulOutcome? I think it\u0027s not critical, given that \u0027procedureCode\u0027 is present in all union members at the same position. But still may be confusing.", "range": { "startLine": 90, "startChar": 63, "endLine": 90, "endChar": 82 }, "revId": "0ef8e2eaed69c0923c9e224859d01ee66a77bf03", "serverId": "035e6965-6537-41bd-912c-053f3cf69326" }, { "unresolved": false, "key": { "uuid": "53eece89_29e35e55", "filename": "src/ranap_common_ran.c", "patchSetId": 5 }, "lineNbr": 90, "author": { "id": 1000028 }, "writtenOn": "2022-01-31T16:42:22Z", "side": 1, "message": "Oh, thats indeed wrong.", "parentUuid": "7030b23e_7396dc5d", "range": { "startLine": 90, "startChar": 63, "endLine": 90, "endChar": 82 }, "revId": "0ef8e2eaed69c0923c9e224859d01ee66a77bf03", "serverId": "035e6965-6537-41bd-912c-053f3cf69326" }, { "unresolved": true, "key": { "uuid": "da00cf9b_8956d22e", "filename": "src/ranap_common_ran.c", "patchSetId": 5 }, "lineNbr": 102, "author": { "id": 1000010 }, "writtenOn": "2022-01-29T10:16:47Z", "side": 1, "message": "outcome? I think it\u0027s not critical, given that \u0027procedureCode\u0027 is present in all union members at the same position. But still may be confusing.", "range": { "startLine": 102, "startChar": 63, "endLine": 102, "endChar": 82 }, "revId": "0ef8e2eaed69c0923c9e224859d01ee66a77bf03", "serverId": "035e6965-6537-41bd-912c-053f3cf69326" }, { "unresolved": false, "key": { "uuid": "b2a9c055_5a06f869", "filename": "src/ranap_common_ran.c", "patchSetId": 5 }, "lineNbr": 102, "author": { "id": 1000028 }, "writtenOn": "2022-01-31T16:42:22Z", "side": 1, "message": "Done", "parentUuid": "da00cf9b_8956d22e", "range": { "startLine": 102, "startChar": 63, "endLine": 102, "endChar": 82 }, "revId": "0ef8e2eaed69c0923c9e224859d01ee66a77bf03", "serverId": "035e6965-6537-41bd-912c-053f3cf69326" }, { "unresolved": true, "key": { "uuid": "2ef5a507_79f42b5f", "filename": "src/ranap_common_ran.c", "patchSetId": 5 }, "lineNbr": 124, "author": { "id": 1000010 }, "writtenOn": "2022-01-29T10:16:47Z", "side": 1, "message": "copy-paste: successful", "range": { "startLine": 124, "startChar": 8, "endLine": 124, "endChar": 20 }, "revId": "0ef8e2eaed69c0923c9e224859d01ee66a77bf03", "serverId": "035e6965-6537-41bd-912c-053f3cf69326" }, { "unresolved": false, "key": { "uuid": "6afc7803_8b20c04e", "filename": "src/ranap_common_ran.c", "patchSetId": 5 }, "lineNbr": 124, "author": { "id": 1000028 }, "writtenOn": "2022-01-31T16:42:22Z", "side": 1, "message": "Done", "parentUuid": "2ef5a507_79f42b5f", "range": { "startLine": 124, "startChar": 8, "endLine": 124, "endChar": 20 }, "revId": "0ef8e2eaed69c0923c9e224859d01ee66a77bf03", "serverId": "035e6965-6537-41bd-912c-053f3cf69326" }, { "unresolved": true, "key": { "uuid": "0b68a617_a523c973", "filename": "src/ranap_common_ran.c", "patchSetId": 5 }, "lineNbr": 132, "author": { "id": 1000010 }, "writtenOn": "2022-01-29T10:16:47Z", "side": 1, "message": "Neither unsuccessful not successful, so this word should be removed.", "range": { "startLine": 132, "startChar": 8, "endLine": 132, "endChar": 20 }, "revId": "0ef8e2eaed69c0923c9e224859d01ee66a77bf03", "serverId": "035e6965-6537-41bd-912c-053f3cf69326" }, { "unresolved": false, "key": { "uuid": "6811ad06_5e934f42", "filename": "src/ranap_common_ran.c", "patchSetId": 5 }, "lineNbr": 132, "author": { "id": 1000028 }, "writtenOn": "2022-01-31T16:42:22Z", "side": 1, "message": "Done", "parentUuid": "0b68a617_a523c973", "range": { "startLine": 132, "startChar": 8, "endLine": 132, "endChar": 20 }, "revId": "0ef8e2eaed69c0923c9e224859d01ee66a77bf03", "serverId": "035e6965-6537-41bd-912c-053f3cf69326" } ] }