This is an option enabled by default and not existent as cmdline param
since asn1c 0.9.26.
For some reason, when dropping it, asn1c generates different description
comment section on related files. In any case, this makes hnbap look
like other libraries which already got this param removed and hence also
generateds code looks the same.
Change-Id: Iccf81539a5045416185e619d24c3d542204437e6
Other libraries already use ASN1C_PREFIX except the HNBAP one. Let's use
it here to avoid collisions.
All new include/osmocom/hnbap/HNBAP_*.h and src/hnbap/HNBAP_*.c are
generated using the updated src/hnbap/Makefile.am.
Files such as src/*.c, test/* and include/osmocom/hnbap/hnbap_common.h
are modified manually to update structs/enums to new prefix.
Related: SYS#5516
Change-Id: I6c062f631527ae42811bfec134933671c05ecba6
Fix the conflict from having %{_includedir}/* in multiple packages by
replacing it with the correct subdir path.
Fix for:
found conflict of libosmo-hnbap-devel-0.7.0.11.b110.202110260026-1.1.armv7hl with libosmo-ranap-devel-0.7.0.11.b110.202110260026-1.1.armv7hl:
- /usr/include/osmocom/hnbap/Access-stratum-release-indicator.h
- /usr/include/osmocom/hnbap/AccessResult.h
- /usr/include/osmocom/hnbap/AdditionalNeighbourInfoList.h
...
I've verified that it builds again in my own OBS namespace.
Related: SYS#5516
Fixes: 35f2bd ("Provide libosmo-hnbap as a public shared library")
Fixes: dba8b0 ("Provide libosmo-rua as a public shared library")
Change-Id: Ia401caf01fa9ea351f811d7c22a04ccff556d6bc
This makes builds reproducible and keep the existing relative path.
This should have been done in a previous commit changing the paths being
passed to asn1c to be absolute (top_srcdir).
Fixes: f67803684f
Change-Id: I19537f136cbb654950172ee532027920d353a556
This allows the SGSN always having feedback on the resolution of the
release, hence being able to stay in PMM CONNECTED state until the
resolution is received, then moving to PMM IDLE.
Related: SYS#5389
Change-Id: Iac822c74e56750dc40e94573eae0e20853ff68c0
Remove hnbgw_vty_reference from the source tree.
In manuals/Makefile.am use the new BUILT_REFERENCE_XML feature recently added
to osmo-gsm-manuals, and add a build target to generate the XML using the new
osmo-hnbgw --vty-ref-xml cmdline switch.
Change-Id: Ia1e978ad9139c41368cd2720c339e1738d345c4a
Depends: I613d692328050a036d05b49a436ab495fc2087ba
Related: OS#5041
For some unknown reason, using size=0 instead of 1 makes LeakSanitizer
report a leak when calling osmo-hnbgw --vty-ref-xml:
"""
==19857==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 96 byte(s) in 1 object(s) allocated from:
#0 0x7f083b4d0d28 in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.3+0xc1d28)
#1 0x7f083a8e5661 in talloc_named_const (/usr/lib/x86_64-linux-gnu/libtalloc.so.2+0x6661)
"""
It seems iu_client.c is already using size=1.
Change-Id: I383653c981e68a053babd33dee1f0df8731752b0
This global variable is already defined in iu_client.c provided by
libosmo-ranap (and used by libasn1c).
Fixes ASan warning at starutp.
Change-Id: I7dbae83ce0dc4ac25dc10879e223280414f7b561
Let's disable category here since we don't care about its formatting here.
In any case, every test relying on logging output validation should
always explicitly state the config to avoid issues in the future if
default values change.
Change-Id: Ia633cae0a26f294e276b431a82256abb1b57ebba
Related: OS#5034
The related compiler warnings were overlooked as due to the
asn1c-generated code there always are tons of warnings printed compiling
this project :(
Change-Id: I40b1265ba696501cc72e674f3ef4146c47aacf1b
So far we don't really have any way of matching a given log message
to a specific hNB. Let's use the newly-introduced LOGHNB() macro.
Change-Id: Ia16eed4ca5e9ef231259e94c65105f7586f366bc
we unconditionally depend on this header file, yet nothing
in configure.ac ensures its presence. Building on a clean
Debian 10 with all existing dependencies installed passes
configure but fails at compilation time.
Change-Id: I0a4407ef6ee512ad5ea8775d90acfe1c4fa67cd0
So far we don't really have any way of matching a given log message
to a specific hNB. Let's introduce a new log macro, together with
a configuration directive to select whether the hNB-ID or the
UMTS CellID shall be used.
Change-Id: I6113925216c6f88add2c6d27bdf47ccbb017f293
