From e9849d1757646d76d7e71f14f420a90726e6d800 Mon Sep 17 00:00:00 2001 From: Gerrit User 1000074 <1000074@035e6965-6537-41bd-912c-053f3cf69326> Date: Mon, 14 Nov 2022 15:09:12 +0000 Subject: [PATCH] Update patch set 3 Patch Set 3: Code-Review+1 (1 comment) Patch-set: 3 Reviewer: Gerrit User 1000074 <1000074@035e6965-6537-41bd-912c-053f3cf69326> Label: Code-Review=+1 Attention: {"person_ident":"Gerrit User 1000147 \u003c1000147@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"pespin replied on the change"} Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"pespin replied on the change"} --- f49cfa030f324f8c2ea6bfaaaf6ac6ab219fc102 | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/f49cfa030f324f8c2ea6bfaaaf6ac6ab219fc102 b/f49cfa030f324f8c2ea6bfaaaf6ac6ab219fc102 index ad5a9fa3..e054eac9 100644 --- a/f49cfa030f324f8c2ea6bfaaaf6ac6ab219fc102 +++ b/f49cfa030f324f8c2ea6bfaaaf6ac6ab219fc102 @@ -35,6 +35,24 @@ "revId": "f49cfa030f324f8c2ea6bfaaaf6ac6ab219fc102", "serverId": "035e6965-6537-41bd-912c-053f3cf69326" }, + { + "unresolved": false, + "key": { + "uuid": "3b4cb193_b5916b6b", + "filename": "/PATCHSET_LEVEL", + "patchSetId": 3 + }, + "lineNbr": 0, + "author": { + "id": 1000074 + }, + "writtenOn": "2022-11-14T15:09:12Z", + "side": 1, + "message": "ACK. IIUC you didn\u0027t detect any code change required after this change in the users of the lib? In any case it may make sense to apply the renaming only for fields count \u003e 1 (so that if there\u0027s 2 or more fields colliding, the first one is kept the old way).", + "parentUuid": "34434083_8f1b8aa9", + "revId": "f49cfa030f324f8c2ea6bfaaaf6ac6ab219fc102", + "serverId": "035e6965-6537-41bd-912c-053f3cf69326" + }, { "unresolved": true, "key": {