cellular-infrastructure
/
osmo-iuh
mirror of https://gerrit.osmocom.org/osmo-iuh
9
0
Fork 0
Code Issues Releases Wiki Activity

hnb-test: Fix memleak in hnb_read_cb 

Change-Id: I6ecbce6aab11e1382ff9f71d901e1c6ac145f835
This commit is contained in:
Pau Espin 2021-10-29 15:45:21 +02:00 committed by pespin
parent 1ddedcfa46
commit df5fb9adf2
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/tests/hnb-test.c
View File

@ -583,22 +583,22 @@ static int hnb_read_cb(struct osmo_fd *fd)
/* FIXME: clean up after disappeared HNB */ /* FIXME: clean up after disappeared HNB */
close(fd->fd); close(fd->fd);
osmo_fd_unregister(fd); osmo_fd_unregister(fd);
return rc; goto free_ret;
} else if (rc == 0) { } else if (rc == 0) {
LOGP(DMAIN, LOGL_INFO, "Connection to HNB closed\n"); LOGP(DMAIN, LOGL_INFO, "Connection to HNB closed\n");
close(fd->fd); close(fd->fd);
osmo_fd_unregister(fd); osmo_fd_unregister(fd);
fd->fd = -1; fd->fd = -1;
rc = -1;
return -1; goto free_ret;
} else { } else {
msgb_put(msg, rc); msgb_put(msg, rc);
} }
if (flags & MSG_NOTIFICATION) { if (flags & MSG_NOTIFICATION) {
LOGP(DMAIN, LOGL_DEBUG, "Ignoring SCTP notification\n"); LOGP(DMAIN, LOGL_DEBUG, "Ignoring SCTP notification\n");
msgb_free(msg); rc = 0;
return 0; goto free_ret;
} }
sinfo.sinfo_ppid = ntohl(sinfo.sinfo_ppid); sinfo.sinfo_ppid = ntohl(sinfo.sinfo_ppid);
@ -626,6 +626,7 @@ static int hnb_read_cb(struct osmo_fd *fd)
break; break;
} }
free_ret:
msgb_free(msg); msgb_free(msg);
return rc; return rc;
} }