Update patch set 5

Patch Set 5:

(6 comments)

Patch-set: 5
CC: Gerrit User 1000010 <1000010@035e6965-6537-41bd-912c-053f3cf69326>
This commit is contained in:
Gerrit User 1000010 2022-01-29 10:16:47 +00:00 committed by Gerrit Code Review
parent 84de3a1440
commit 89dd52a9b0
1 changed files with 136 additions and 0 deletions

View File

@ -0,0 +1,136 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "8be6c60c_63158110",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 5
},
"lineNbr": 0,
"author": {
"id": 1000010
},
"writtenOn": "2022-01-29T10:16:47Z",
"side": 1,
"message": "Mostly cosmetic notes, not a merge blocker.",
"revId": "0ef8e2eaed69c0923c9e224859d01ee66a77bf03",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "27b84377_1802f520",
"filename": "include/osmocom/ranap/ranap_common.h",
"patchSetId": 5
},
"lineNbr": 599,
"author": {
"id": 1000010
},
"writtenOn": "2022-01-29T10:16:47Z",
"side": 1,
"message": "Tippfehler: functions",
"range": {
"startLine": 599,
"startChar": 36,
"endLine": 599,
"endChar": 45
},
"revId": "0ef8e2eaed69c0923c9e224859d01ee66a77bf03",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "7030b23e_7396dc5d",
"filename": "src/ranap_common_ran.c",
"patchSetId": 5
},
"lineNbr": 90,
"author": {
"id": 1000010
},
"writtenOn": "2022-01-29T10:16:47Z",
"side": 1,
"message": "successfulOutcome? I think it\u0027s not critical, given that \u0027procedureCode\u0027 is present in all union members at the same position. But still may be confusing.",
"range": {
"startLine": 90,
"startChar": 63,
"endLine": 90,
"endChar": 82
},
"revId": "0ef8e2eaed69c0923c9e224859d01ee66a77bf03",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "da00cf9b_8956d22e",
"filename": "src/ranap_common_ran.c",
"patchSetId": 5
},
"lineNbr": 102,
"author": {
"id": 1000010
},
"writtenOn": "2022-01-29T10:16:47Z",
"side": 1,
"message": "outcome? I think it\u0027s not critical, given that \u0027procedureCode\u0027 is present in all union members at the same position. But still may be confusing.",
"range": {
"startLine": 102,
"startChar": 63,
"endLine": 102,
"endChar": 82
},
"revId": "0ef8e2eaed69c0923c9e224859d01ee66a77bf03",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "2ef5a507_79f42b5f",
"filename": "src/ranap_common_ran.c",
"patchSetId": 5
},
"lineNbr": 124,
"author": {
"id": 1000010
},
"writtenOn": "2022-01-29T10:16:47Z",
"side": 1,
"message": "copy-paste: successful",
"range": {
"startLine": 124,
"startChar": 8,
"endLine": 124,
"endChar": 20
},
"revId": "0ef8e2eaed69c0923c9e224859d01ee66a77bf03",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "0b68a617_a523c973",
"filename": "src/ranap_common_ran.c",
"patchSetId": 5
},
"lineNbr": 132,
"author": {
"id": 1000010
},
"writtenOn": "2022-01-29T10:16:47Z",
"side": 1,
"message": "Neither unsuccessful not successful, so this word should be removed.",
"range": {
"startLine": 132,
"startChar": 8,
"endLine": 132,
"endChar": 20
},
"revId": "0ef8e2eaed69c0923c9e224859d01ee66a77bf03",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}