Update patch set 3

Patch Set 3:

(2 comments)

Patch-set: 3
CC: Gerrit User 1000074 <1000074@035e6965-6537-41bd-912c-053f3cf69326>
Attention: {"person_ident":"Gerrit User 1000147 \u003c1000147@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"pespin replied on the change"}
This commit is contained in:
Gerrit User 1000074 2022-11-14 12:31:31 +00:00 committed by Gerrit Code Review
parent 4ce8d13b0d
commit 82f0185563
1 changed files with 38 additions and 0 deletions

View File

@ -0,0 +1,38 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "b151b64d_f74ccfd0",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 3
},
"lineNbr": 0,
"author": {
"id": 1000074
},
"writtenOn": "2022-11-14T12:31:31Z",
"side": 1,
"message": "So you seem to fix some code generation in this patch, but I don\u0027t see any .c/.h files changes. Is that because the as1nstruct is called dynamically during build time?",
"revId": "f49cfa030f324f8c2ea6bfaaaf6ac6ab219fc102",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "f67e31ea_1fa3837a",
"filename": "asn1/utils/asn1tostruct.py",
"patchSetId": 3
},
"lineNbr": 84,
"author": {
"id": 1000074
},
"writtenOn": "2022-11-14T12:31:31Z",
"side": 1,
"message": "Did you think about simply adding a suffix to it? like a counter if count !\u003d 1?",
"revId": "f49cfa030f324f8c2ea6bfaaaf6ac6ab219fc102",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}