Update patch set 2

Patch Set 2:

(1 comment)

Patch-set: 2
CC: Gerrit User 1000004 <1000004@035e6965-6537-41bd-912c-053f3cf69326>
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"laforge replied on the change"}

b81e6b64ac8c1bd92c02256b4cec38ee1da0bec8

@@ -16,6 +16,24 @@
       "message": "I\u0027m not sure we want to touch the asn files.\nIf at all maybe adding some step to copy them and \"sed\" them or alike.",
       "revId": "b81e6b64ac8c1bd92c02256b4cec38ee1da0bec8",
       "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "cae50727_f8aed2e2",
+        "filename": "/PATCHSET_LEVEL",
+        "patchSetId": 2
+      },
+      "lineNbr": 0,
+      "author": {
+        "id": 1000004
+      },
+      "writtenOn": "2022-11-11T22:00:33Z",
+      "side": 1,
+      "message": "The asn1 files were already modified quite a bit to make asn1c digest them at all.  look at the git commit log of the asn1 subdirectory and you\u0027ll find commits like 355d9513c0359ec10de79cc12b6e8a2d4e81e8d8  \"Rewrite to avoid information object classes\".\n\nSo there\u0027s no difference here, other than it\u0027s \u0027just\u0027 warnings.\n\nWhat I\u0027m more worried about is that I don\u0027t have deep enough ASN.1 and various encoding rules knowledge if this kind of change really doesn\u0027t affect the binary encoding/decoding.  Only encoding/decoding tests with a reasonably sized body of binary messages would make us notice that, right?",
+      "parentUuid": "77caef14_9933af34",
+      "revId": "b81e6b64ac8c1bd92c02256b4cec38ee1da0bec8",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
     }
   ]
 }