cellular-infrastructure
/
osmo-iuh
mirror of https://gerrit.osmocom.org/osmo-iuh
9
0
Fork 0
Code Issues Releases Wiki Activity

hnbap: Free ASN.1 components after they are no longer needed

This commit is contained in:
Daniel Willmann 2015-12-17 17:56:56 +01:00
parent 6637a289da
commit 59d17d8961
2 changed files with 20 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/hnbap_common.c
View File

@ -141,7 +141,7 @@ struct msgb *hnbap_generate_initiating_message(
Criticality_t criticality,
asn_TYPE_descriptor_t * td, void *sptr)
{
struct msgb *msg;
HNBAP_PDU_t pdu;
int rc;
@ -156,7 +156,10 @@ struct msgb *hnbap_generate_initiating_message(
return NULL;
}
return _hnbap_gen_msg(&pdu);
msg = _hnbap_gen_msg(&pdu);
ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_HNBAP_PDU, &pdu);
return msg;
}
struct msgb *hnbap_generate_successful_outcome(
@ -165,7 +168,7 @@ struct msgb *hnbap_generate_successful_outcome(
asn_TYPE_descriptor_t * td,
void *sptr)
{
struct msgb *msg;
HNBAP_PDU_t pdu;
int rc;
@ -180,7 +183,10 @@ struct msgb *hnbap_generate_successful_outcome(
return NULL;
}
return _hnbap_gen_msg(&pdu);
msg = _hnbap_gen_msg(&pdu);
ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_HNBAP_PDU, &pdu);
return msg;
}
struct msgb *hnbap_generate_unsuccessful_outcome(
@ -189,7 +195,7 @@ struct msgb *hnbap_generate_unsuccessful_outcome(
asn_TYPE_descriptor_t * td,
void *sptr)
{
struct msgb *msg;
HNBAP_PDU_t pdu;
int rc;
@ -204,7 +210,10 @@ struct msgb *hnbap_generate_unsuccessful_outcome(
return NULL;
}
return _hnbap_gen_msg(&pdu);
msg = _hnbap_gen_msg(&pdu);
ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_HNBAP_PDU, &pdu);
return msg;
}
IE_t *hnbap_new_ie(ProtocolIE_ID_t id,
@ -214,7 +223,7 @@ IE_t *hnbap_new_ie(ProtocolIE_ID_t id,
IE_t *buff;
if ((buff = malloc(sizeof(IE_t))) == NULL) {
if ((buff = MALLOC(sizeof(IE_t))) == NULL) {
// Possible error on malloc
return NULL;
}

4
src/hnbgw_hnbap.c
View File

@ -69,6 +69,8 @@ static int hnbgw_tx_hnb_register_acc(struct hnb_context *ctx)
&asn_DEF_HNBRegisterAccept,
&accept_out);
ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_HNBRegisterAccept, &accept_out);
return hnbgw_hnbap_tx(ctx, msg);
}
@ -294,6 +296,8 @@ int hnbgw_hnbap_rx(struct hnb_context *hnb, struct msgb *msg)
rc = _hnbgw_hnbap_rx(hnb, pdu);
ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_HNBAP_PDU, pdu);
return rc;
}