Update patch set 3

Patch Set 3:

(2 comments)

Patch-set: 3
Attention: {"person_ident":"Gerrit User 1000147 \u003c1000147@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"osmith replied on the change"}
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"osmith replied on the change"}
This commit is contained in:
Gerrit User 1000147 2022-11-14 12:47:13 +00:00 committed by Gerrit Code Review
parent 82f0185563
commit 3d8b4b8401
1 changed files with 36 additions and 0 deletions

View File

@ -17,6 +17,24 @@
"revId": "f49cfa030f324f8c2ea6bfaaaf6ac6ab219fc102",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "34434083_8f1b8aa9",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 3
},
"lineNbr": 0,
"author": {
"id": 1000147
},
"writtenOn": "2022-11-14T12:47:13Z",
"side": 1,
"message": "Yes. Here is the diff of the generated files with this patch: https://gitea.osmocom.org/osmith/osmo-iuh-generated-files/commit/80129270353912bad8e74cb1f0b13ee742559562",
"parentUuid": "b151b64d_f74ccfd0",
"revId": "f49cfa030f324f8c2ea6bfaaaf6ac6ab219fc102",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
@ -33,6 +51,24 @@
"message": "Did you think about simply adding a suffix to it? like a counter if count !\u003d 1?",
"revId": "f49cfa030f324f8c2ea6bfaaaf6ac6ab219fc102",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "37a3bf1a_6ba209a1",
"filename": "asn1/utils/asn1tostruct.py",
"patchSetId": 3
},
"lineNbr": 84,
"author": {
"id": 1000147
},
"writtenOn": "2022-11-14T12:47:13Z",
"side": 1,
"message": "If somebody needs to actually use them / or debug the generated code for whatever reason, I think it\u0027s more useful to have the name of the field instead of a number. Because then you would need to look up the number again to know which field it actually is.",
"parentUuid": "f67e31ea_1fa3837a",
"revId": "f49cfa030f324f8c2ea6bfaaaf6ac6ab219fc102",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}