From 3241d053d93d75119b1612b24a7bac3076d82fbd Mon Sep 17 00:00:00 2001 From: Gerrit User 1000147 <1000147@035e6965-6537-41bd-912c-053f3cf69326> Date: Mon, 14 Nov 2022 12:28:59 +0000 Subject: [PATCH] Update patch set 1 Patch Set 1: (1 comment) Patch-set: 1 Attention: {"person_ident":"Gerrit User 1000147 \u003c1000147@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"osmith replied on the change"} Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"osmith replied on the change"} --- 02036368c9069f172aabfae8cb24ecd9890ff5af | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/02036368c9069f172aabfae8cb24ecd9890ff5af b/02036368c9069f172aabfae8cb24ecd9890ff5af index c6731b32..8f388cf8 100644 --- a/02036368c9069f172aabfae8cb24ecd9890ff5af +++ b/02036368c9069f172aabfae8cb24ecd9890ff5af @@ -33,6 +33,24 @@ "message": "Ah I see now that you are dropping it from places where it is not really used.", "revId": "02036368c9069f172aabfae8cb24ecd9890ff5af", "serverId": "035e6965-6537-41bd-912c-053f3cf69326" + }, + { + "unresolved": false, + "key": { + "uuid": "83e6d4b0_cf80beba", + "filename": "/PATCHSET_LEVEL", + "patchSetId": 1 + }, + "lineNbr": 0, + "author": { + "id": 1000147 + }, + "writtenOn": "2022-11-14T12:28:59Z", + "side": 1, + "message": "I\u0027m not dropping it from ranap_cn_rx_co and ranap_cn_rx_cl, but only from functions that these are calling in the same file. Because these functions don\u0027t use ctx at all, so imho having it there just makes the whole code more confusing as it\u0027s not clear whether ctx is for userdata or a talloc context when looking only at parts of it.", + "parentUuid": "43c2411e_d26d9841", + "revId": "02036368c9069f172aabfae8cb24ecd9890ff5af", + "serverId": "035e6965-6537-41bd-912c-053f3cf69326" } ] } \ No newline at end of file