cellular-infrastructure
/
osmo-iuh
mirror of https://gerrit.osmocom.org/osmo-iuh
9
0
Fork 0
Code Issues Releases Wiki Activity

fix PDU leaks in rua_generate_*() functions 

Related: SYS#6297
Change-Id: I04eb1455e1fd43c239f352470bf971b73eb8b205
This commit is contained in:
Neels Hofmeyr 2023-04-27 05:44:42 +02:00 committed by neels
parent be0b55e047
commit 29d7e780fc
1 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/rua_common.c
View File

@ -134,6 +134,7 @@ struct msgb *rua_generate_initiating_message(
{
RUA_RUA_PDU_t pdu;
int rc;
struct msgb *msg;
memset(&pdu, 0, sizeof(pdu));
@ -146,7 +147,9 @@ struct msgb *rua_generate_initiating_message(
return NULL;
}
return _rua_gen_msg(&pdu);
msg = _rua_gen_msg(&pdu);
ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_RUA_RUA_PDU, &pdu);
return msg;
}
struct msgb *rua_generate_successful_outcome(
@ -157,6 +160,7 @@ struct msgb *rua_generate_successful_outcome(
{
RUA_RUA_PDU_t pdu;
int rc;
struct msgb *msg;
memset(&pdu, 0, sizeof(pdu));
@ -169,7 +173,9 @@ struct msgb *rua_generate_successful_outcome(
return NULL;
}
return _rua_gen_msg(&pdu);
msg = _rua_gen_msg(&pdu);
ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_RUA_RUA_PDU, &pdu);
return msg;
}
struct msgb *rua_generate_unsuccessful_outcome(
@ -180,6 +186,7 @@ struct msgb *rua_generate_unsuccessful_outcome(
{
RUA_RUA_PDU_t pdu;
int rc;
struct msgb *msg;
memset(&pdu, 0, sizeof(pdu));
@ -192,7 +199,9 @@ struct msgb *rua_generate_unsuccessful_outcome(
return NULL;
}
return _rua_gen_msg(&pdu);
msg = _rua_gen_msg(&pdu);
ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_RUA_RUA_PDU, &pdu);
return msg;
}
RUA_IE_t *rua_new_ie(RUA_ProtocolIE_ID_t id,