cellular-infrastructure
/
osmo-iuh
mirror of https://gerrit.osmocom.org/osmo-iuh
9
0
Fork 0
Code Issues Releases Wiki Activity

hnbgw: zero-initialize the output struct before aper_decode() 

asn1c has this strange behavior that the _output_ struct must be
zero-initialized.
This commit is contained in:
Harald Welte 2015-09-07 21:10:50 +02:00
parent 5c11c94637
commit 2204f9d43d
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/hnbgw_hnbap.c
View File

@ -31,6 +31,7 @@ static int hnbgw_tx_hnb_register_acc(struct hnb_context *ctx)
};
/* encode the Information Elements */
memset(&accept_out, 0, sizeof(accept_out));
rc = hnbap_encode_hnbregisteraccepties(&accept_out, &accept);
if (rc < 0) {
return rc;
@ -54,8 +55,10 @@ static int hnbgw_tx_ue_register_acc(struct ue_context *ue)
int rc;
/* FIXME accept.uE_Identity; */
memset(&accept, 0, sizeof(accept));
asn1_u32_to_bitstring(&accept.context_ID, &ue->context_id);
memset(&accept_out, 0, sizeof(accept_out));
rc = hnbap_encode_ueregisteraccepties(&accept_out, &accept);
if (rc < 0) {
return rc;
@ -179,6 +182,7 @@ int hnbgw_hnbap_rx(struct hnb_context *hnb, struct msgb *msg)
/* decode and handle to _hnbgw_hnbap_rx() */
memset(pdu, 0, sizeof(*pdu));
dec_ret = aper_decode(NULL, &asn_DEF_HNBAP_PDU, (void **) &pdu,
msg->data, msgb_length(msg), 0, 0);
if (dec_ret.code != RC_OK) {