cellular-infrastructure
/
osmo-hnodeb
mirror of https://gerrit.osmocom.org/osmo-hnodeb
9
0
Fork 0
Code Issues Releases Wiki Activity

Fix several Coverity found issues 

Closes: CID#242770
Closes: CID#242769
Closes: CID#242767
Change-Id: I6d73a970919889953539fbacc601d679d7ec4113
This commit is contained in:
Pau Espin 2021-12-16 12:58:49 +01:00
parent a7dc04ef26
commit ecc76ef69a
2 changed files with 11 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/osmo-hnodeb/gtp.c
View File

@ -45,14 +45,15 @@ static int hnb_gtp_cb_data_ind(struct pdp_t *lib, void *packet, unsigned int len
{
struct hnb_gtp_prim *gtp_prim;
struct hnb_ue *ue = lib->priv;
struct hnb *hnb = ue->hnb;
struct hnb *hnb;
int rc;
if (!ue || !ue->conn_ps.active) {
LOGUE(ue, DGTP, LOGL_NOTICE, "Tx GTP-CONN_DATA.ind data=%p len=%u but UE conn_ps is not active!\n",
LOGP(DGTP, LOGL_NOTICE, "Tx GTP-CONN_DATA.ind data=%p len=%u but UE conn_ps is not active!\n",
packet, len);
return -EINVAL;
}
hnb = ue->hnb;
LOGUE(ue, DGTP, LOGL_DEBUG, "Tx GTP-CONN_DATA.ind data=%p len=%u\n", packet, len);
gtp_prim = hnb_gtp_makeprim_conn_data_ind(ue->conn_id, ue->conn_ps.local_tei, packet, len);
@ -180,18 +181,19 @@ int hnb_ue_gtp_bind(struct hnb_ue *ue, const struct osmo_sockaddr *rem_addr, uin
int hnb_ue_gtp_tx(struct hnb_ue *ue, void *gtpu_payload, unsigned gtpu_payload_len)
{
int rc;
struct hnb *hnb = ue->hnb;
if (!hnb->gtp.gsn) {
LOGUE(ue, DGTP, LOGL_ERROR, "Tx: GTP socket not bound\n");
return -EINVAL;
}
struct hnb *hnb;
if (!ue || !ue->conn_ps.pdp_lib) {
LOGUE(ue, DGTP, LOGL_ERROR, "Tx: UE PDP Ctx not available\n");
return -EINVAL;
}
hnb = ue->hnb;
if (!hnb->gtp.gsn) {
LOGUE(ue, DGTP, LOGL_ERROR, "Tx: GTP socket not bound\n");
return -EINVAL;
}
rc = gtp_data_req(hnb->gtp.gsn, ue->conn_ps.pdp_lib, gtpu_payload, gtpu_payload_len);
return rc;
}

1
src/osmo-hnodeb/rua.c
View File

@ -140,6 +140,7 @@ static int hnb_rua_rx_initiating(struct hnb *hnb, RUA_InitiatingMessage_t *init)
case RUA_ProcedureCode_id_DirectTransfer:
LOGP(DRUA, LOGL_INFO, "RUA rx Initiating DirectTransfer\n");
hnb_rua_dt_handle(hnb, &init->value);
break;
default:
LOGP(DRUA, LOGL_INFO, "RUA rx unknown Initiating message\n");
break;