From 70b65c55f63ba08e869d5776c5baeda98142a415 Mon Sep 17 00:00:00 2001
From: Pau Espin Pedrol <pespin@sysmocom.de>
Date: Fri, 7 Jan 2022 13:44:29 +0100
Subject: [PATCH] gtp: Fix uninitialized var if no extension flags set in gtp
 header

The logic was plain wrong, bug introduced while typing initial code.

Closes: Coverity CID#243535
Change-Id: I497667edd0571fff91ab41c8b57bdcf277e5988d
---
 src/osmo-hnodeb/gtp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/osmo-hnodeb/gtp.c b/src/osmo-hnodeb/gtp.c
index c22de65..ef12cf6 100644
--- a/src/osmo-hnodeb/gtp.c
+++ b/src/osmo-hnodeb/gtp.c
@@ -246,7 +246,7 @@ static int hnb_gtp_wq_read_cb(struct osmo_fd *fd)
 
 	if (hdr->s || hdr->pn || hdr->e)
 		opt_hdr_len = 4;
-	if (hdr->pn)
+	else
 		opt_hdr_len = 0;
 
 	if (msgb_length(msg) < sizeof(*hdr) + opt_hdr_len) {