110 lines
3.6 KiB
Plaintext
110 lines
3.6 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "098a2c98_67e39dd0",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1000004
|
|
},
|
|
"writtenOn": "2024-04-02T09:49:43Z",
|
|
"side": 1,
|
|
"message": "I think what\u0027s missign is some flag to enable/disable the suppor for this. Not everyone will want those stats, and not everyone is willing to run the process with CAP_NET_ADMIN and not everyone will want it to fiddle with nftables rules.\n\nI think ideally we\u0027d have both a compile-time switch to enable/disable the feature (to build without libnftables requirement), and then some runtime configuration to decide if the program (when it has support compiled in) should add those nft rules or not.",
|
|
"revId": "b32a0bb81839d14b55e3d6ddedec1075fb58331b",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "6905dda3_d02e24f7",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1000005
|
|
},
|
|
"writtenOn": "2024-04-02T22:09:22Z",
|
|
"side": 1,
|
|
"message": "I agree; I see this patch at a stage where we evaluate whether the approach works good enough. Stopped myself from adding compiler switches etc yet.",
|
|
"parentUuid": "098a2c98_67e39dd0",
|
|
"revId": "b32a0bb81839d14b55e3d6ddedec1075fb58331b",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "e0538cdb_ff86b731",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1000005
|
|
},
|
|
"writtenOn": "2024-04-02T22:10:35Z",
|
|
"side": 1,
|
|
"message": "current problem is getting it to pass the gerrit verification, which has problems with the nftables dependencies on debian 10.",
|
|
"revId": "b32a0bb81839d14b55e3d6ddedec1075fb58331b",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "93e5e8f5_68a4524d",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1000005
|
|
},
|
|
"writtenOn": "2024-04-02T22:55:36Z",
|
|
"side": 1,
|
|
"message": "right, it appears we need a compiler switch for the gerrit verification, too. So now is the time, after all.",
|
|
"parentUuid": "6905dda3_d02e24f7",
|
|
"revId": "b32a0bb81839d14b55e3d6ddedec1075fb58331b",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "9343f18e_9751dc35",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1000005
|
|
},
|
|
"writtenOn": "2024-04-09T03:55:18Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "93e5e8f5_68a4524d",
|
|
"revId": "b32a0bb81839d14b55e3d6ddedec1075fb58331b",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "836e753d_75de01a8",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1000005
|
|
},
|
|
"writtenOn": "2024-04-09T03:55:18Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "e0538cdb_ff86b731",
|
|
"revId": "b32a0bb81839d14b55e3d6ddedec1075fb58331b",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
}
|
|
]
|
|
} |