hnbgw_rx_hnb_deregister: Don't call hnb_context_release()

Don't release the HNB context as there's plenty of code that
assumes there's always a HNB context associated with a SCTP connection.

Instead, simply unset the hnb_registered flag in the context when
processing a HNB_DE-REGISTER.

Related: OS#5676

Change-Id: Id5c4f5c900ea049f54afbf58edb84b4dc00b1dcb
changes/32/29332/2
Harald Welte 3 months ago committed by Pau Espin Pedrol
parent c971c657c5
commit d3382ae952
  1. 4
      include/osmocom/hnbgw/hnbgw.h
  2. 2
      src/osmo-hnbgw/hnbgw_hnbap.c

@ -84,6 +84,7 @@ struct hnbgw_cnlink {
struct llist_head map_list;
};
/* The lifecycle of the hnb_context object is the same as its conn */
struct hnb_context {
/*! Entry in HNB-global list of HNB */
struct llist_head list;
@ -101,8 +102,7 @@ struct hnb_context {
/*! SCTP stream ID for RUA */
uint16_t rua_stream;
/*! True if a HNB-REGISTER-REQ from this HNB has been accepted. Note that
* this entire data structure is freed if the HNB sends HNB-DE-REGISTER-REQ. */
/*! True if a HNB-REGISTER-REQ from this HNB has been accepted. */
bool hnb_registered;
/* linked list of hnbgw_context_map */

@ -388,7 +388,7 @@ static int hnbgw_rx_hnb_deregister(struct hnb_context *ctx, ANY_t *in)
LOGHNB(ctx, DHNBAP, LOGL_DEBUG, "HNB-DE-REGISTER cause=%s\n", hnbap_cause_str(&ies.cause));
hnbap_free_hnbde_registeries(&ies);
hnb_context_release(ctx);
ctx->hnb_registered = false;
return 0;
}

Loading…
Cancel
Save