Update patch set 2

Patch Set 2: Code-Review+2

(1 comment)

Patch-set: 2
Reviewer: Gerrit User 1000004 <1000004@035e6965-6537-41bd-912c-053f3cf69326>
Label: Code-Review=+2
Attention: {"person_ident":"Gerrit User 1000004 \u003c1000004@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"laforge replied on the change"}
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"laforge replied on the change"}
This commit is contained in:
Gerrit User 1000004 2022-08-09 16:34:48 +00:00 committed by Gerrit Code Review
parent 55b8ada7c8
commit 615eba48b8
1 changed files with 18 additions and 0 deletions

View File

@ -33,6 +33,24 @@
"message": "Do we really want to disable PFCP support at build time? Is that really going to be used and it is worth it to maintain that? I\u0027m fine with simply disabling it at runtime.",
"revId": "e6201765cf67eb01e5f3066072ddf1b5e6970961",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "7b3981cb_fbf31222",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 1000004
},
"writtenOn": "2022-08-09T16:34:48Z",
"side": 1,
"message": "our existing apporoach is to try to minimize dependencies, see osmo-msc with default-off for smpp or Iu support.\n\nThe advantage of this approach is that it makes it easier for people to build a simple/typical setup from source, without cursing over all the dependencies.\n\nFor our package feeds it\u0027s not an issue as we can simply pass --enable-foo in the debian/rules.",
"parentUuid": "d2c6db5a_29017343",
"revId": "e6201765cf67eb01e5f3066072ddf1b5e6970961",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}