From 10855555e92c99e1b0adb2d195824312da93e284 Mon Sep 17 00:00:00 2001 From: Andreas Schultz Date: Mon, 16 Nov 2015 16:06:43 +0100 Subject: [PATCH] gtp: remove genl_register_family_with_ops for Linux < 3.13 Remove the support for genl_register_family_with_ops for Linux < 3.13. Also reorder the initialization to be more in line with similar modules. Signed-off-by: Andreas Schultz Signed-off-by: Pablo Neira Ayuso --- gtp.c | 25 ++++++++++--------------- 1 file changed, 10 insertions(+), 15 deletions(-) diff --git a/gtp.c b/gtp.c index 11bda38..fbfc806 100644 --- a/gtp.c +++ b/gtp.c @@ -1321,35 +1321,30 @@ static int __init gtp_init(void) get_random_bytes(>p_h_initval, sizeof(gtp_h_initval)); -#if LINUX_VERSION_CODE >= KERNEL_VERSION(3, 13, 0) - err = genl_register_family_with_ops(>p_genl_family, gtp_genl_ops); - if (err < 0) - return err; -#else - err = genl_register_family_with_ops(>p_genl_family, - gtp_genl_ops, - ARRAY_SIZE(gtp_genl_ops)); - if (err < 0) - return err; -#endif err = rtnl_link_register(>p_link_ops); if (err < 0) - goto err1; + goto error_out; + + err = genl_register_family_with_ops(>p_genl_family, gtp_genl_ops); + if (err < 0) + goto unreg_rtnl_link; pr_info("GTP module loaded (pdp ctx size %Zd bytes)\n", sizeof(struct pdp_ctx)); return 0; -err1: + +unreg_rtnl_link: + rtnl_link_unregister(>p_link_ops); +error_out: pr_err("error loading GTP module loaded\n"); - genl_unregister_family(>p_genl_family); return err; } late_initcall(gtp_init); static void __exit gtp_fini(void) { - rtnl_link_unregister(>p_link_ops); genl_unregister_family(>p_genl_family); + rtnl_link_unregister(>p_link_ops); pr_info("GTP module unloaded\n"); }