0af893c79d
So far the resources.conf says we're using XOR, but we wrongly map 'xor' to 1, which is actually comp128v1 in enum osmo_auth_algo from libosmocore (which osmo-hlr uses to interpret the numbers from the hlr.db). This explains why our "xor" tests are succeeding even though libosmocore doesn't support XOR at all: we were using comp128v1 all the while. Fix the auth algo mapping: - define correct mappings, copying enum osmo_auth_algo, in util.py - add a function to get the enum value from name, in util.py - use this in osmo_hlr.py Change subscriber_add() API to take the algorithm string instead of a number. The number is libosmocore internal and we should not expose it within our API beyond above dict. There are no callers using this parameter yet anyway. Adjust resources.conf to indicate COMP128v1 which we are actually using and which means we're still using algorithm number 1 after this change. BTW, osmo-nitb uses the ctrl interface which interprets the names, so is not vulnerable to mapping wrong numbers and needs no fix. (If osmo-hlr featured similar CTRL, which it doesn't yet, this code could be more robust.) Related: OS#2758 Change-Id: I7a6ce92468a6ae46136ad4f62381da261fd196c8 |
||
---|---|---|
.. | ||
scenarios | ||
README.txt | ||
default-suites.conf | ||
defaults.conf | ||
paths.conf | ||
resources.conf |
README.txt
This a real gsm test suite configured and ready to use. The only thing missing is a trial dir containing binaries. You can point osmo-gsm-tester.py at this config using the OSMO_GSM_TESTER_CONF environment variable: export OSMO_GSM_TESTER_CONF="$PWD" When there is no OSMO_GSM_TESTER_CONF set, osmo-gsm-tester will instead look for conf files in several locations like ~/.config/osmo-gsm-tester, /usr/local/etc/osmo-gsm-tester, /etc/osmo-gsm-tester. If you have your trial with binary tar archives in ~/my_trial you can run the suite for example like this: osmo-gsm-tester.py ~/my_trial Specifically, from this dir: OSMO_GSM_TESTER_CONF="$PWD" ../src/osmo-gsm-tester.py ~/my_trial Alternatively you can setup this example as permanent config using something like: mkdir -p ~/.config ln -s "$PWD" ~/.config/osmo-gsm-tester A ./state dir will be created to store the current osmo-gsm-tester state. If you prefer not to write to $PWD, set up an own configuration pointing at a different path (see paths.conf: 'state_dir').