From dcc0b5577c0c90f3e7f9af0b886dd07cbaaf1961 Mon Sep 17 00:00:00 2001 From: Alejandro Leal Conejos Date: Tue, 15 Jun 2021 17:57:55 +0200 Subject: [PATCH] util: fix the functions "create_netns" and "setcap_netsys_admin". This commit fixes 2 functions from util.py: - setcap_netsys_admin: removed "self" from the arguments. - create_netns: pass "run_dir" to Process and convert the arguments to a list as the other methods in the file. Change-Id: Ida4c6d6500be92b8d1f96e4e7a870e63bd329be9 --- src/osmo_gsm_tester/core/util.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/osmo_gsm_tester/core/util.py b/src/osmo_gsm_tester/core/util.py index 691b4897..5ca6ad90 100644 --- a/src/osmo_gsm_tester/core/util.py +++ b/src/osmo_gsm_tester/core/util.py @@ -102,7 +102,7 @@ def setcap_net_admin(binary, run_dir): proc = Process(SETCAP_NET_ADMIN_BIN, run_dir, ['sudo', SETCAP_NET_ADMIN_BIN, binary]) proc.launch_sync() -def setcap_netsys_admin(self, binary, run_dir): +def setcap_netsys_admin(binary, run_dir): ''' This functionality requires specific setup on the host running osmo-gsm-tester. See osmo-gsm-tester manual for more information. @@ -118,7 +118,7 @@ def create_netns(netns, run_dir): ''' from .process import Process NETNS_SETUP_BIN = 'osmo-gsm-tester_netns_setup.sh' - proc = Process('create_netns', ('sudo', NETNS_SETUP_BIN, netns)) + proc = Process('create_netns',run_dir, ['sudo', NETNS_SETUP_BIN, netns]) proc.launch_sync() def move_iface_to_netns(ifname, netns, run_dir):