From ecef920b8facd61438c8b4d3a288111186b0c1a6 Mon Sep 17 00:00:00 2001 From: Harald Welte Date: Sat, 27 Mar 2021 19:00:34 +0100 Subject: [PATCH] ggsn: Reject PDP CTX ACT for static IP addresses We don't implement handling of static IP addresses for now, let's properly reject those rather than allocating a dynamic address anyway. Change-Id: Iac8868438655fe4e5e07d167d7dbd6273dbb7678 Related: OS#5097 --- ggsn/ggsn.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/ggsn/ggsn.c b/ggsn/ggsn.c index 267637d..bde7f4b 100644 --- a/ggsn/ggsn.c +++ b/ggsn/ggsn.c @@ -467,9 +467,13 @@ int create_context_ind(struct pdp_t *pdp) return 0; } - /* FIXME: we manually force all context requests to dynamic here! */ - if (pdp->eua.l > 2) - pdp->eua.l = 2; + /* FIXME: implement context request for static IP addresses! */ + if (pdp->eua.l > 2) { + LOGPPDP(LOGL_ERROR, pdp, "Static IP addresses not supported: %s\n", + osmo_hexdump(pdp->eua.v, pdp->eua.l)); + gtp_create_context_resp(gsn, pdp, GTPCAUSE_NOT_SUPPORTED); + return 0; + } memcpy(pdp->qos_neg0, pdp->qos_req0, sizeof(pdp->qos_req0));